Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass after 2031 #1279

Merged
merged 12 commits into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Mar 8, 2019

Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our python-apache-libcloud package build.

With this patch, tests completed successfully on i586 and x86_64 in 2034

See https://reproducible-builds.org/ for the overall topic - only slightly relevant here.

  • done, ready for review

  • Code linting (required, can be done after the PR checks)

  • Documentation

  • Tests

  • ICLA (required for bigger changes)

Make tests pass after 2031
note: tests completed successfully on i586 and x86_64 in 2034
@vdloo

This comment has been minimized.

Copy link
Member

vdloo commented Mar 10, 2019

cool 👍

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

bmwiedemann commented Mar 11, 2019

ryanpetrello and others added some commits Mar 11, 2019

Merge pull request #1280 from ryanpetrello/gce-crypto
Replace all usage of PyCrypto with python-cryptography
@Kami

This comment has been minimized.

Copy link
Member

Kami commented Mar 19, 2019

Thanks, the change looks good to me.

It looks like https://issues.apache.org/jira/browse/LIBCLOUD-1038 is related to an actual limitation / issue in the xmlrpclib from Python stdlib? And probably nothing we can do about it.

I would imagine that probably already got changed / fixed in Python 3.x?

@Kami

This comment has been minimized.

Copy link
Member

Kami commented Mar 19, 2019

Some related Python issues:

It looks like a solution / workaround for VCL test failure would be to send string integer of an integer when number is larger than 32 bits (and assume VCL API handles that correctly).

@Kami

This comment has been minimized.

Copy link
Member

Kami commented Mar 19, 2019

I pushed a change which I believe will fix the test failure mentioned in https://issues.apache.org/jira/browse/LIBCLOUD-1038.

It looks like the method already expects a string for start argument (per docstring), so it should be safe and correct thing to do that.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #1279 into trunk will increase coverage by 0.04%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1279      +/-   ##
==========================================
+ Coverage   85.91%   85.95%   +0.04%     
==========================================
  Files         359      359              
  Lines       73777    73774       -3     
  Branches     6689     6690       +1     
==========================================
+ Hits        63386    63413      +27     
+ Misses       7719     7687      -32     
- Partials     2672     2674       +2
Impacted Files Coverage Δ
libcloud/test/common/test_google.py 97.23% <ø> (+2.76%) ⬆️
libcloud/test/compute/test_softlayer.py 92.74% <0%> (+2.66%) ⬆️
libcloud/common/google.py 65.33% <0%> (+3.33%) ⬆️
libcloud/compute/drivers/softlayer.py 84.79% <0%> (-1.09%) ⬇️
libcloud/utils/py3.py 46.25% <0%> (ø) ⬆️
libcloud/test/test_utils.py 95.13% <100%> (+0.21%) ⬆️
libcloud/compute/drivers/vcl.py 88.88% <100%> (ø) ⬆️
libcloud/test/compute/test_openstack.py 95.1% <100%> (ø) ⬆️
libcloud/utils/publickey.py 56% <58.33%> (+30.07%) ⬆️
libcloud/test/compute/test_upcloud.py 91.39% <0%> (+1.32%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8735a7...2491149. Read the comment docs.

@Kami Kami merged commit a1f9897 into apache:trunk Mar 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kami

This comment has been minimized.

Copy link
Member

Kami commented Mar 19, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.