[LIBCLOUD-1043] Fix Azure upload_object_via_stream used with iter#1287
Merged
Kami merged 1 commit intoapache:trunkfrom May 28, 2019
CatalystCode:1043_fix_azure_upload_object_via_stream_with_iterator
Merged
[LIBCLOUD-1043] Fix Azure upload_object_via_stream used with iter#1287Kami merged 1 commit intoapache:trunkfrom CatalystCode:1043_fix_azure_upload_object_via_stream_with_iterator
Kami merged 1 commit intoapache:trunkfrom
CatalystCode:1043_fix_azure_upload_object_via_stream_with_iterator
Conversation
Member
Author
|
Tagging @michaelperel since he last modified this code. |
Kami
reviewed
May 26, 2019
Codecov Report
@@ Coverage Diff @@
## trunk #1287 +/- ##
==========================================
+ Coverage 85.98% 85.98% +<.01%
==========================================
Files 359 359
Lines 73809 73824 +15
Branches 6698 6698
==========================================
+ Hits 63466 63481 +15
Misses 7666 7666
Partials 2677 2677
Continue to review full report at Codecov.
|
Kami
approved these changes
May 28, 2019
Member
|
Merged, thanks. |
asfgit
pushed a commit
that referenced
this pull request
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Azure upload_object_via_stream used with iter
Description
As described in LIBCLOUD-1043, the Azure Blob Storage driver currently doesn't support use-cases like this:
This is due to the fact that the current implementation of
upload_object_via_streamassumes that the passed-in iterator always implementsseek. This pull request adds a fallback for iterators where this is not the case.Status
Checklist (tick everything that applies)