-
Notifications
You must be signed in to change notification settings - Fork 924
[LIBCLOUD-1001] Update Cloudflare DNS driver to API v4 #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1292 +/- ##
=========================================
+ Coverage 85.9% 85.91% +<.01%
=========================================
Files 365 365
Lines 75137 75056 -81
Branches 6858 6861 +3
=========================================
- Hits 64547 64484 -63
+ Misses 7825 7809 -16
+ Partials 2765 2763 -2
Continue to review full report at Codecov.
|
|
Tagging @Kami as the original author of the Cloudflare DNS driver. |
|
@c-w Thanks for the contribution. Since it's a bigger change, signed ICLA is required (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes). |
|
Thanks for the patience @Kami. The ICLA is now signed. |
Kami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
I think it would be good to release v2.6.0 in the near future once this PR and a couple of other ones are merged. Do you want to try the release process for v2.6.0? |
|
Thanks for the review @Kami and yes, I'd be happy to go through the release flow for |
Update Cloudflare DNS driver to API v4
Description
As discussed in LIBCLOUD-1001, Cloudflare turned off the old JSON API and replaced it with the new v4 API. This pull request updates the Cloudflare DNS driver to use the new API.
Note that in order to keep the implementation of the v4 driver streamlined, none of the existing
ex_methods were migrated to the new API.Note that LIBCLOUD-994 is also fixed by the new driver implementation.
Status
Checklist (tick everything that applies)