Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-1001] Update Cloudflare DNS driver to API v4 #1292

Merged
merged 5 commits into from Jul 17, 2019

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented May 30, 2019

Update Cloudflare DNS driver to API v4

Description

As discussed in LIBCLOUD-1001, Cloudflare turned off the old JSON API and replaced it with the new v4 API. This pull request updates the Cloudflare DNS driver to use the new API.

Note that in order to keep the implementation of the v4 driver streamlined, none of the existing ex_ methods were migrated to the new API.

Note that LIBCLOUD-994 is also fixed by the new driver implementation.

Status

Checklist (tick everything that applies)

@codecov-io

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #1292 into trunk will increase coverage by <.01%.
The diff coverage is 96.32%.

Impacted file tree graph

@@            Coverage Diff            @@
##           trunk    #1292      +/-   ##
=========================================
+ Coverage   85.9%   85.91%   +<.01%     
=========================================
  Files        365      365              
  Lines      75137    75056      -81     
  Branches    6858     6861       +3     
=========================================
- Hits       64547    64484      -63     
+ Misses      7825     7809      -16     
+ Partials    2765     2763       -2
Impacted Files Coverage Δ
libcloud/test/dns/test_cloudflare.py 100% <100%> (+1.42%) ⬆️
libcloud/dns/drivers/cloudflare.py 95.18% <93.87%> (+5.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817fdeb...d394d41. Read the comment docs.

@c-w c-w force-pushed the CatalystCode:1001_update-cloudflare-dns-v4 branch 5 times, most recently from b3214e9 to e7c5408 May 30, 2019

@c-w

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Tagging @Kami as the original author of the Cloudflare DNS driver.

@c-w c-w force-pushed the CatalystCode:1001_update-cloudflare-dns-v4 branch 2 times, most recently from d36d165 to e107fdb May 30, 2019

@Kami

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

@c-w Thanks for the contribution.

Since it's a bigger change, signed ICLA is required (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes).

@c-w

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

Thanks for the patience @Kami. The ICLA is now signed.

@c-w c-w force-pushed the CatalystCode:1001_update-cloudflare-dns-v4 branch from e107fdb to 0f627e5 Jul 15, 2019

@c-w c-w requested a review from Kami Jul 16, 2019

@c-w c-w force-pushed the CatalystCode:1001_update-cloudflare-dns-v4 branch from aa68e5c to 35a02ee Jul 16, 2019

@Kami

Kami approved these changes Jul 17, 2019

Copy link
Member

left a comment

LGTM.

@Kami

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

I think it would be good to release v2.6.0 in the near future once this PR and a couple of other ones are merged.

Do you want to try the release process for v2.6.0?

@c-w c-w force-pushed the CatalystCode:1001_update-cloudflare-dns-v4 branch from 35a02ee to d394d41 Jul 17, 2019

@c-w c-w merged commit 59bb977 into apache:trunk Jul 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:1001_update-cloudflare-dns-v4 branch Jul 17, 2019

@c-w

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Thanks for the review @Kami and yes, I'd be happy to go through the release flow for v2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.