[LIBCLOUD-851] Fix azure_blobs driver with BlobStorage account #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://docs.microsoft.com/en-us/rest/api/storagerp/storageaccounts/create#kind, there are several types of storage accounts that can be created in Azure including: StorageV2 (default), Storage and BlobStorage. As per https://docs.microsoft.com/en-us/rest/api/storageservices/versioning-for-the-azure-storage-services, StorageV2 and Storage support API versions of `2009-09-19` or newer. BlobStorage only supports API versions of `2014-02-14` or newer. In order to ensure that libcloud works with all the types of storage accounts, this change raises the API version used by the storage driver to the earliest version supported by all the account types.
4 tasks
Codecov Report
@@ Coverage Diff @@
## trunk #1294 +/- ##
==========================================
- Coverage 85.95% 85.95% -0.01%
==========================================
Files 359 359
Lines 73911 73912 +1
Branches 6705 6705
==========================================
- Hits 63530 63529 -1
- Misses 7699 7700 +1
- Partials 2682 2683 +1
Continue to review full report at Codecov.
|
|
@cicorias @michaelperel @jmspring could one of you please review this? |
|
@c-w I was hoping you will be able to merge this yourself :) |
|
I went ahead and merged this bug fix into trunk. Thanks @c-w and @daviskirk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix azure_blobs driver with BlobStorage account
Description
As discussed in LIBCLOUD-851, the Azure Storage driver currently doesn't work when used against a storage account that was created using
kind=BlobStorage(see failed integration test). This is because BlobStorage accounts only work with API version2014-02-14or newer (see docs). Updating the API version fixes the problem and doesn't affect the other types of storage accounts (see passed integration test).Note that this pull request is based on the work of @daviskirk in #1202.
Status
Checklist (tick everything that applies)