Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum requests version #1325

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@c-w
Copy link
Member

commented Jul 26, 2019

Specify minimum requests version

Description

The investigation in #1322, has led to the discovery that there are errors in the libcloud Azure Storage driver with any requests version below 2.5.0. As such, this pull request updates setup.py to ensure that the requests dependency is at least that version.

Status

  • done, ready for review

Checklist (tick everything that applies)

@Kami

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

LGTM, thanks 👍

Show resolved Hide resolved CHANGES.rst Outdated
@Kami

Kami approved these changes Jul 28, 2019

@c-w c-w force-pushed the CatalystCode:specify-minimum-requests-version branch from c202b86 to 5fe2332 Aug 2, 2019

@c-w c-w force-pushed the CatalystCode:specify-minimum-requests-version branch from 5fe2332 to cef3139 Aug 2, 2019

@c-w c-w force-pushed the CatalystCode:specify-minimum-requests-version branch from cef3139 to f418b36 Aug 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #1325 into trunk will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1325   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         367      367           
  Lines       75303    75303           
  Branches     6886     6886           
=======================================
  Hits        64965    64965           
  Misses       7561     7561           
  Partials     2777     2777

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b45f76...f418b36. Read the comment docs.

@c-w c-w merged commit 69db55f into apache:trunk Aug 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:specify-minimum-requests-version branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.