Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1322] Detect broken yum install python-requests #1332

Merged
merged 8 commits into from Aug 23, 2019
Merged

[GH-1322] Detect broken yum install python-requests #1332

merged 8 commits into from Aug 23, 2019

Conversation

@c-w
Copy link
Member

@c-w c-w commented Aug 2, 2019

Detect issues with libcloud and python-requests on RHEL 7

Description

As discussed in #1322, libcloud breaks when used on RHEL 7.6 with requests installed from yum instead of PyPI. In order to prevent user confusion, this pull request introduces a check for this environment state and provides guidance for the user on how to correctly set up their system for libcloud to function.

Resolves #1322

Status

  • done, ready for review

Checklist (tick everything that applies)

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 2, 2019

Codecov Report

Merging #1332 into trunk will decrease coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1332      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files         372      372              
  Lines       75825    75845      +20     
  Branches     6928     6929       +1     
==========================================
+ Hits        65473    65489      +16     
- Misses       7569     7572       +3     
- Partials     2783     2784       +1
Impacted Files Coverage Δ
libcloud/compute/drivers/gce.py 76.84% <100%> (+0.01%) ⬆️
libcloud/test/compute/test_gce.py 97.77% <100%> (ø) ⬆️
libcloud/test/test_init.py 85.29% <100%> (+4.52%) ⬆️
libcloud/__init__.py 67.64% <75%> (+2.26%) ⬆️
libcloud/test/compute/test_upcloud.py 90.06% <0%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e109ed6...8d179ed. Read the comment docs.

Loading

@Kami
Copy link
Member

@Kami Kami commented Aug 3, 2019

Can you please also add a test case for it?

On a related note - we should also advise uses to use virtualenv with no system packages in such scenario (that's a good practice in general).

Loading

libcloud/__init__.py Outdated Show resolved Hide resolved
Loading
@c-w c-w requested a review from Kami Aug 12, 2019
@c-w
Copy link
Member Author

@c-w c-w commented Aug 14, 2019

@Kami I believe I addressed all the comments. I also verified that python setup.py install works on a clean virtualenv. Could you please take another look and let me know if this is ready for merge? Thanks!

Loading

Kami
Kami approved these changes Aug 23, 2019
@Kami
Copy link
Member

@Kami Kami commented Aug 23, 2019

Sorry for the delay. I pushed a small change (8d179ed), besides that it looks good to me 👍

Loading

@Kami
Copy link
Member

@Kami Kami commented Aug 23, 2019

@c-w a lot of changes have accumulated in trunk since the last release.

Do you want to start the work needed to get the 2.6.0 release out - https://libcloud.readthedocs.io/en/latest/committer_guide.html#making-a-release-for-release-managers?

Loading

@Kami Kami merged commit 18a510f into apache:trunk Aug 23, 2019
1 check passed
Loading
@c-w c-w deleted the detect-broken-yum-python-requests branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants