-
Notifications
You must be signed in to change notification settings - Fork 925
[GH-1322] Detect broken yum install python-requests
#1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1322] Detect broken yum install python-requests
#1332
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1332 +/- ##
==========================================
- Coverage 86.34% 86.34% -0.01%
==========================================
Files 372 372
Lines 75825 75845 +20
Branches 6928 6929 +1
==========================================
+ Hits 65473 65489 +16
- Misses 7569 7572 +3
- Partials 2783 2784 +1
Continue to review full report at Codecov.
|
|
Can you please also add a test case for it? On a related note - we should also advise uses to use virtualenv with no system packages in such scenario (that's a good practice in general). |
|
@Kami I believe I addressed all the comments. I also verified that |
…latform_field Add missing cpu platform field to GCE driver
…m/CatalystCode/libcloud into CatalystCode-detect-broken-yum-python-requests
|
Sorry for the delay. I pushed a small change (8d179ed), besides that it looks good to me 👍 |
|
@c-w a lot of changes have accumulated in trunk since the last release. Do you want to start the work needed to get the 2.6.0 release out - https://libcloud.readthedocs.io/en/latest/committer_guide.html#making-a-release-for-release-managers? |
Detect issues with libcloud and python-requests on RHEL 7
Description
As discussed in #1322, libcloud breaks when used on RHEL 7.6 with requests installed from yum instead of PyPI. In order to prevent user confusion, this pull request introduces a check for this environment state and provides guidance for the user on how to correctly set up their system for libcloud to function.
Resolves #1322
Status
Checklist (tick everything that applies)