Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1322] Detect broken `yum install python-requests` #1332

Open
wants to merge 2 commits into
base: trunk
from

Conversation

@c-w
Copy link
Member

commented Aug 2, 2019

Detect issues with libcloud and python-requests on RHEL 7

Description

As discussed in #1322, libcloud breaks when used on RHEL 7.6 with requests installed from yum instead of PyPI. In order to prevent user confusion, this pull request introduces a check for this environment state and provides guidance for the user on how to correctly set up their system for libcloud to function.

Resolves #1322

Status

  • done, ready for review

Checklist (tick everything that applies)

@c-w c-w force-pushed the CatalystCode:detect-broken-yum-python-requests branch from 98a50f2 to bea70b5 Aug 2, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 2, 2019

Codecov Report

Merging #1332 into trunk will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1332      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files         372      372              
  Lines       75825    75837      +12     
  Branches     6928     6929       +1     
==========================================
+ Hits        65473    65483      +10     
- Misses       7569     7571       +2     
  Partials     2783     2783
Impacted Files Coverage Δ
libcloud/test/test_init.py 83.33% <100%> (+2.56%) ⬆️
libcloud/__init__.py 67.64% <75%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e109ed6...ec2c908. Read the comment docs.

@Kami

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Can you please also add a test case for it?

On a related note - we should also advise uses to use virtualenv with no system packages in such scenario (that's a good practice in general).

Show resolved Hide resolved libcloud/__init__.py Outdated

@c-w c-w force-pushed the CatalystCode:detect-broken-yum-python-requests branch from bea70b5 to 1a2ffea Aug 12, 2019

@c-w c-w requested a review from Kami Aug 12, 2019

@c-w c-w force-pushed the CatalystCode:detect-broken-yum-python-requests branch from 1a2ffea to ec2c908 Aug 12, 2019

@c-w

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

@Kami I believe I addressed all the comments. I also verified that python setup.py install works on a clean virtualenv. Could you please take another look and let me know if this is ready for merge? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.