Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Blob Storage API version to 2016-05-31 #1340

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@c-w
Copy link
Member

commented Aug 11, 2019

Update Azure Blob Storage API version to 2016-05-31

Description

To enable the Azure Blobs driver to upload larger files, this pull request updates the blob storage API version used by the driver to 2016-05-31 which raised the size of block blobs that can be uploaded in a single request to 100MB.

To leverage the full capacity of the new storage API version, the maximum block size in the Azure Blobs driver is also increased to 100MB. A code comment from 2013 cautioned about Azure instability on requests over 4MB, however, I haven't seen any stability issues with this change during over 200 runs of the integration tests using file uploads ranging from 4MB to 100MB.

Given that the Azure Blobs driver currently does not support chunked upload, increasing the maximum upload size seems to me like a pragmatic fix to expand the driver's functionality until a more comprehensive refactor can be made to re-instate the block-list workflow.

Status

  • done, ready for review

Checklist

@c-w c-w force-pushed the CatalystCode:azure-blobs-api-version-update branch from 6008e85 to 73055d4 Aug 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #1340 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1340      +/-   ##
==========================================
+ Coverage   86.33%   86.34%   +<.01%     
==========================================
  Files         371      372       +1     
  Lines       75794    75825      +31     
  Branches     6928     6928              
==========================================
+ Hits        65440    65471      +31     
  Misses       7570     7570              
  Partials     2784     2784
Impacted Files Coverage Δ
libcloud/common/azure.py 84.76% <100%> (+0.76%) ⬆️
libcloud/test/common/test_azure.py 100% <100%> (ø)
libcloud/storage/drivers/azure_blobs.py 69.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd3403...7b49fda. Read the comment docs.

Show resolved Hide resolved libcloud/common/azure.py Outdated
@Kami

Kami approved these changes Aug 12, 2019

@c-w c-w force-pushed the CatalystCode:azure-blobs-api-version-update branch from 2eafc6d to 7b49fda Aug 12, 2019

@c-w c-w merged commit e109ed6 into apache:trunk Aug 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:azure-blobs-api-version-update branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.