Update Azure Blob Storage API version to 2016-05-31 #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1340 +/- ##
==========================================
+ Coverage 86.33% 86.34% +<.01%
==========================================
Files 371 372 +1
Lines 75794 75825 +31
Branches 6928 6928
==========================================
+ Hits 65440 65471 +31
Misses 7570 7570
Partials 2784 2784
Continue to review full report at Codecov.
|
Kami
reviewed
Aug 12, 2019
Kami
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Azure Blob Storage API version to 2016-05-31
Description
To enable the Azure Blobs driver to upload larger files, this pull request updates the blob storage API version used by the driver to 2016-05-31 which raised the size of block blobs that can be uploaded in a single request to 100MB.
To leverage the full capacity of the new storage API version, the maximum block size in the Azure Blobs driver is also increased to 100MB. A code comment from 2013 cautioned about Azure instability on requests over 4MB, however, I haven't seen any stability issues with this change during over 200 runs of the integration tests using file uploads ranging from 4MB to 100MB.
Given that the Azure Blobs driver currently does not support chunked upload, increasing the maximum upload size seems to me like a pragmatic fix to expand the driver's functionality until a more comprehensive refactor can be made to re-instate the block-list workflow.
Status
Checklist