Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python used in Windows CI to 3.8 #1404

Merged
merged 1 commit into from Jan 9, 2020
Merged

Conversation

@c-w
Copy link
Member

c-w commented Jan 9, 2020

Fix CI on Windows

Description

The Travis CI build on Windows is currently failing (e.g. see 5073.4 or 5074.4) due to an error installing Python via Chocolatey.

This pull request fixes the CI by updating the build to use the latest Python published to Chocolatey (3.8). This also required updating the cryptography dependency to the latest version (2.8) since the previously pinned version (2.6.1) doesn't include a wheel for Python 3.8 on Windows.

Status

  • done, ready for review

Checklist

  • Code linting (n/a, infrastructure-only change)
  • Documentation (n/a, infrastructure-only change)
  • Tests (CI passed)
  • ICLA (committer)
@c-w c-w requested a review from Kami Jan 9, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #1404 into trunk will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1404   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files         366      366           
  Lines       76751    76751           
  Branches     7527     7527           
=======================================
  Hits        66352    66352           
  Misses       7532     7532           
  Partials     2867     2867

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a97ab73...634f60c. Read the comment docs.

@Kami

This comment has been minimized.

Copy link
Member

Kami commented Jan 9, 2020

Thanks for the fix.

If I understand correctly, chocolatey on Travis only supports a single (latest) version of Python 3?

@Kami
Kami approved these changes Jan 9, 2020
@c-w c-w force-pushed the CatalystCode:fix-windows-ci branch from 7c95a95 to 6e11135 Jan 9, 2020
@c-w

This comment has been minimized.

Copy link
Member Author

c-w commented Jan 9, 2020

Turns out this was a temporary (but persistent over multiple hours) bug with Chocolatey yesterday which failed installs when --version was specified. While the issue now seems resolved (e.g. see successful build which pins Python 3.8.1 and one which pins Python 3.7.5), I'd say that it's still worth merging this PR to get the Windows CI updated to the latest Python version. I'll rename the PR before merge.

@c-w c-w changed the title Fix CI on Windows Update Python used in Windows CI to 3.8 Jan 9, 2020
@c-w c-w force-pushed the CatalystCode:fix-windows-ci branch from 6e11135 to 634f60c Jan 9, 2020
@c-w c-w merged commit 89eaa4f into apache:trunk Jan 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@c-w c-w deleted the CatalystCode:fix-windows-ci branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.