Add support for Azure Government to Azure Blobs storage driver #1552
Conversation
Note that this change also enables using the driver with Azure China and Azure Private Link.
| @@ -217,15 +221,34 @@ def __init__(self, key, secret=None, secure=True, host=None, port=None, | |||
| port=port, **kwargs) | |||
|
|
|||
| def _ex_connection_class_kwargs(self): | |||
There was a problem hiding this comment.
Some unit tests for this method would be good.
| # still use the same scheme to identify a specific account as for | ||
| # the standard storage endpoint | ||
| try: | ||
| host_suffix = next( |
There was a problem hiding this comment.
Is there a situation where we may want to allow end user to specify full host as-is - aka so we don't add any prefix to it, but user already includes that in the host argument?
I think this would give users more flexibility in some situations.
There was a problem hiding this comment.
To clarify - if a new endpoint ever gets added or similar, this would require use to update the code to support it.
If we allowed user to specify a full arbitrary host, they may be able to use that instead (until a new version is released / similar).
For us to be able to support that, we would likely need to add new argument to the constructor - e.g. ex_use_host_as_is / ex_dont_prefix_host (or some better name, can't come up with anything better atm).
There was a problem hiding this comment.
The only current Azure Storage version that I'm aware of which wouldn't be covered by the approach proposed in this PR is Azure Stack Hub Storage. However the API version that libcloud uses (2018-11-09) is newer than the latest supported version of Azure Stack (2017-11-09) so libcloud doesn't support it anyways.
I get the appeal of an ex_force_host or similar argument, but I wonder if the simplicity of this explicit approach will be more user-friendly as it doesn't introduce an argument that's specific to just this driver and instead manages the complexity internally. Thoughts?
There was a problem hiding this comment.
Yeah, I didn't really mean it as an alternative, but in addition to your proposed changes (so the interface for the common case would still be the same, but in case there is a need to use a fully custom host, there is an easy way to do it).
I also don't think that's a blocker for this PR so if you think it's a good idea, feel free to open a new PR with that change in the future.
There was a problem hiding this comment.
In that case I'd say to defer the addition of ex_force_host for now.
c-w
force-pushed
the
storage-azureblobs-fix-1551-govcloud
branch
from
f9313bd
to
b16eb28
Compare
…e#1552) * Fix typo in documentation * Add support for blob storage in Azure Government Note that this change also enables using the driver with Azure China and Azure Private Link. * Add unit tests for GovCloud host formatting * Add unit tests for Azurite host formatting * Allow conn_kwargs to override host
…e#1552) * Fix typo in documentation * Add support for blob storage in Azure Government Note that this change also enables using the driver with Azure China and Azure Private Link. * Add unit tests for GovCloud host formatting * Add unit tests for Azurite host formatting * Allow conn_kwargs to override host
Add support for Azure Government to Azure Blobs storage driver
Description
This pull request adds support to the Azure Blobs storage driver for deployments of Azure Storage that use custom hostnames such as Azure Government, Azure China, and Azure Private Link. To target these deployments, the driver can be initialized as follows:
The change maintains backwards compatibility with the previous approach of using a custom host argument to target Azurite or IoT Edge Storage by explicitly checking for the Azure China, Azure Government, and Azure Private Link well-known endpoint constants.
Resolves #1551
Status
Checklist