Enable auth to Cloudflare DNS via API Tokens #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
force-pushed
the
dns-cloudflare-token-auth
branch
from
39508bf
to
126b273
Compare
|
@Kami "Generate Code Coverage" failure in this pull request seems unrelated to the changes:
|
This error has been fixed in trunk, merge the changes and this tests will pass. |
Kami
reviewed
Mar 13, 2021
libcloud/dns/drivers/cloudflare.py
Outdated
| @@ -146,27 +147,37 @@ def parse_error(self): | |||
| raise exception_class(**kwargs) | |||
|
|
|||
|
|
|||
| class CloudFlareDNSConnection(ConnectionUserAndKey): | |||
| class BaseDNSConnection: | |||
There was a problem hiding this comment.
Minor style thing - we tend to explicitly inherit from object everywhere.
Kami
approved these changes
Mar 13, 2021
Codecov Report
@@ Coverage Diff @@
## trunk #1564 +/- ##
==========================================
- Coverage 83.00% 83.00% -0.01%
==========================================
Files 394 394
Lines 84943 84959 +16
Branches 9036 9037 +1
==========================================
+ Hits 70508 70521 +13
- Misses 11369 11372 +3
Partials 3066 3066
Continue to review full report at Codecov.
|
d-mo
pushed a commit
to mistio/libcloud
that referenced
this pull request
Nov 15, 2021
d-mo
pushed a commit
to mistio/libcloud
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable auth to Cloudflare DNS via API Tokens
Description
This pull request adds support to the Cloudflare DNS driver to authenticate via API Tokens (see docs) in addition to the previous Global API Key authentication mechanism.
Status
Checklist