Repository navigation
Enable auth to Cloudflare DNS via API Tokens - #1564
Conversation
39508bf to
126b273
Compare
|
@Kami "Generate Code Coverage" failure in this pull request seems unrelated to the changes: |
This error has been fixed in trunk, merge the changes and this tests will pass. |
|
|
||
|
|
||
| class CloudFlareDNSConnection(ConnectionUserAndKey): | ||
| class BaseDNSConnection: |
There was a problem hiding this comment.
Minor style thing - we tend to explicitly inherit from object everywhere.
Kami
left a comment
There was a problem hiding this comment.
LGTM 👍
I use CloudFlare driver myself in various places, so this will also come handy for me :)
Codecov Report
@@ Coverage Diff @@
## trunk #1564 +/- ##
==========================================
- Coverage 83.00% 83.00% -0.01%
==========================================
Files 394 394
Lines 84943 84959 +16
Branches 9036 9037 +1
==========================================
+ Hits 70508 70521 +13
- Misses 11369 11372 +3
Partials 3066 3066
Continue to review full report at Codecov.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #1564 +/- ##
==========================================
- Coverage 83.01% 83.01% -0.00%
==========================================
Files 394 394
Lines 84943 84959 +16
Branches 9036 9037 +1
==========================================
+ Hits 70508 70521 +13
- Misses 11369 11372 +3
Partials 3066 3066
🚀 New features to boost your workflow:
|

Enable auth to Cloudflare DNS via API Tokens
Description
This pull request adds support to the Cloudflare DNS driver to authenticate via API Tokens (see docs) in addition to the previous Global API Key authentication mechanism.
Status
Checklist