Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for MinIO storage driver #1578

Merged
merged 2 commits into from May 2, 2021

Conversation

c-w
Copy link
Member

@c-w c-w commented May 2, 2021

Add integration tests for MinIO storage driver

Description

This pull requests extends the storage integration test framework to cover the MinIO storage driver.

One of the integration tests failed as the S3 driver from which MinIO derives doesn't pass-through content_encoding in get_object so this pull request also adds this missing functionality.

Status

  • done, ready for review

Checklist

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2021

Codecov Report

Merging #1578 (158611f) into trunk (38693a4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1578      +/-   ##
==========================================
- Coverage   83.00%   83.00%   -0.01%     
==========================================
  Files         394      394              
  Lines       84990    84992       +2     
  Branches     9038     9039       +1     
==========================================
  Hits        70550    70550              
- Misses      11373    11374       +1     
- Partials     3067     3068       +1     
Impacted Files Coverage Δ
libcloud/storage/drivers/s3.py 89.46% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38693a4...158611f. Read the comment docs.

@c-w
Copy link
Member Author

c-w commented May 2, 2021

@Kami Do we have any contacts in AWS and/or GCP who'd be willing to get us some cloud credits like we did for Azure? That would enable us to add live tests for those drivers too as they don't seem to have official emulators.

@c-w c-w force-pushed the storage-minio-integration-tests branch from ec4625b to 158611f Compare May 2, 2021 15:39
@Kami
Copy link
Member

Kami commented May 2, 2021

@c-w Yeah, we actually already have some AWS OSS credits and secrets are already set up for this repo (AWS_ACCESS_KEY_ID, AWS_ACCESS_KEY_SECRET).

If needed, I can also give you access to that AWS account.

EDIT: I just checked. We still have 500$ left till beginning of August. If needed, I can request more credits.

Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kami Kami merged commit d8edac3 into trunk May 2, 2021
@Kami Kami deleted the storage-minio-integration-tests branch May 2, 2021 21:15
@c-w
Copy link
Member Author

c-w commented May 3, 2021

Thanks for the review @Kami, and yes, would be great if you could add me to the AWS account as it'll speed up implementation/verification of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants