New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ssh for servers with PubkeyAuthentication only #194

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@mgogoulos
Contributor

mgogoulos commented Dec 13, 2013

conninfo['key_filename'] = self.key
else:
conninfo['allow_agent'] = True

This comment has been minimized.

@Kami

Kami Dec 13, 2013

Member

For explicitness sake and backward compatibility reasons I would prefer to still specify those two options.

@Kami

Kami Dec 13, 2013

Member

For explicitness sake and backward compatibility reasons I would prefer to still specify those two options.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 13, 2013

Member

I needed paramiko docs and ticket description to see what happens if both arguments (multiple authentication methods) are specified.

It appears paramiko just tries different authentication methods in a pre-defined order of priority so this change looks good.

Member

Kami commented Dec 13, 2013

I needed paramiko docs and ticket description to see what happens if both arguments (multiple authentication methods) are specified.

It appears paramiko just tries different authentication methods in a pre-defined order of priority so this change looks good.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Dec 13, 2013

Member

Existing tests are failing btw - https://travis-ci.org/apache/libcloud/builds/15403675.

Those tests need to be fixed / updated. It would also be good to add a new test case which checks what happens when both arguments are specified.

Member

Kami commented Dec 13, 2013

Existing tests are failing btw - https://travis-ci.org/apache/libcloud/builds/15403675.

Those tests need to be fixed / updated. It would also be good to add a new test case which checks what happens when both arguments are specified.

@asfgit asfgit closed this in 039cb79 Jan 8, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 8, 2014

Member

I went ahead fixed the failing tests and made the look_for_keys and allow_agent change described above and merged this patch into trunk.

Thanks!

Member

Kami commented Jan 8, 2014

I went ahead fixed the failing tests and made the look_for_keys and allow_agent change described above and merged this patch into trunk.

Thanks!

@mgogoulos

This comment has been minimized.

Show comment
Hide comment
@mgogoulos

mgogoulos Jan 9, 2014

Contributor

Nice, thanks for adding the tests! Shame for me for postponing for such a long time!

Contributor

mgogoulos commented Jan 9, 2014

Nice, thanks for adding the tests! Shame for me for postponing for such a long time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment