Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue LIBCLOUD-464: Add security group delete/destroy into the EC2 drive... #199
Ugh, sorry, looks like I've missed one thing in my previous review.
For consistency with other drivers, can you please also rename the methods from "destroy" to "delete" (
Besides that, the patch looks good.
While reviewing and merging the patch, I've noticed that you forgot to update
When I find some more time, I'll also have a look at how we can automatically detect and prevent issues like this from happening in the feature. It seems that for a start, we could do a simple integration with coverage.py and make sure that all the newly added test cases are actually executed.