LIBCLOUD-493: Add additional data into the Node.extra dictionary #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizing changes
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
…he 2013-10-15 version of the EC2 API into the Node.extra dictionary. The updates include block device mapping, VPC information and root device information among other. All unit tests were updated accordingly and the fixture has been updated with a more recent XML response.
|
One other note on this PR is that I removed the groups parameter in _to_nodes and now build the security groups list using _get_security_groups. This seemed like a cleaner implementation given that security groups also need to be built for network interfaces as well. |
|
@cderamus Yep, I noticed that and I like this approach more. Changes look good so I've merged them into trunk. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2014
2013-10-15 version of the EC2 API into the Node.extra dictionary. The updates include block device mapping, VPC information and root device information among other. All unit tests were updated accordingly and the fixture has been updated with a more recent XML response. Closes #221. Signed-off-by: Tomaz Muraus <tomaz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR removes libcloud/test/compute/fixtures/ec2/describe_instances_with_tags.xml as it is no longer necessary. The tag tests are done within test_list_nodes now. Also note that I changed the name of a few select properties to match the libcloud standard. As an example clienttoken -> client_token.