New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-493: Add additional data into the Node.extra dictionary #221

Closed
wants to merge 11 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@cderamus
Contributor

cderamus commented Jan 12, 2014

Note that this PR removes libcloud/test/compute/fixtures/ec2/describe_instances_with_tags.xml as it is no longer necessary. The tag tests are done within test_list_nodes now. Also note that I changed the name of a few select properties to match the libcloud standard. As an example clienttoken -> client_token.

cderamus and others added some commits Dec 26, 2013

Chris DeRamus
Issue LIBCLOUD-493: Add extra instance properties that now exist in t…
…he 2013-10-15 version of the EC2 API into the Node.extra dictionary. The updates include block device mapping, VPC information and root device information among other. All unit tests were updated accordingly and the fixture has been updated with a more recent XML response.
@cderamus

This comment has been minimized.

Show comment
Hide comment
@cderamus

cderamus Jan 12, 2014

Contributor

One other note on this PR is that I removed the groups parameter in _to_nodes and now build the security groups list using _get_security_groups. This seemed like a cleaner implementation given that security groups also need to be built for network interfaces as well.

Contributor

cderamus commented Jan 12, 2014

One other note on this PR is that I removed the groups parameter in _to_nodes and now build the security groups list using _get_security_groups. This seemed like a cleaner implementation given that security groups also need to be built for network interfaces as well.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 12, 2014

Member

@cderamus Yep, I noticed that and I like this approach more.

Changes look good so I've merged them into trunk. Thanks!

Member

Kami commented Jan 12, 2014

@cderamus Yep, I noticed that and I like this approach more.

Changes look good so I've merged them into trunk. Thanks!

@cderamus cderamus closed this Jan 12, 2014

asfgit pushed a commit that referenced this pull request Jan 12, 2014

Issue LIBCLOUD-493: Add extra instance properties that now exist in the
2013-10-15 version of the EC2 API into the Node.extra dictionary. The updates
include block device mapping, VPC information and root device information
among other. All unit tests were updated accordingly and the fixture has
been updated with a more recent XML response.

Closes #221.

Signed-off-by: Tomaz Muraus <tomaz@apache.org>

@cderamus cderamus deleted the DivvyCloud:LIBCLOUD-493_Add_Node_Extra_Properties branch Jan 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment