LIBCLOUD-494: Add image extension methods for create/copy #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizing changes
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
Synchronizing fork
…mage calls. The first is ex_copy_image which is used to copy Amazon Machine Images between regions and the second is ex_create_image which can be used to create an AMI from an EBS backed instance.
| @@ -1566,6 +1566,105 @@ def delete_key_pair(self, key_pair): | |||
| namespace=NAMESPACE) | |||
| return element == 'true' | |||
|
|
|||
| def ex_copy_image(self, source_region, image, name=None, description=None): | |||
| """ | |||
| Copy an Amazon Machine Image from one region to another. | |||
There was a problem hiding this comment.
The to be more clear about what is going on, the description should probably say "Copy an Amazon Machine Image from the specified source region to the current region.".
…is used for create_node and ex_create_image_from_node. Changed no_reboot -> reboot to make things a bit more clear within ex_create_image_from_node.
|
Fixed the build issue and merged patch into trunk. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new extension methods to copy AMIs between Amazon regions and also adds the ability to create an image from an EBS backed instance. Unit tests and new fixtures are included.