New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rackspace pagination #230

Closed
wants to merge 8 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@thanatos
Contributor

thanatos commented Jan 24, 2014

A set of commits to handle Rackspace's pagination of results in their DNS API in the Rackspace driver.

Originally in pull request #190, but moved here to clean it up.

Show outdated Hide outdated libcloud/dns/drivers/rackspace.py Outdated
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 24, 2014

Member

@thanatos Looks good. Can you please squash the commits so I can merge patch into trunk?

Member

Kami commented Jan 24, 2014

@thanatos Looks good. Can you please squash the commits so I can merge patch into trunk?

@thanatos

This comment has been minimized.

Show comment
Hide comment
@thanatos

thanatos Jan 24, 2014

Contributor

@Kami: That's an odd request. Why not just merge the branch into trunk? If you really want a squashed commit (you'll lose the history?) there's one at thanatos@rackspace-pagination-squished. (1a8b287)

Contributor

thanatos commented Jan 24, 2014

@Kami: That's an odd request. Why not just merge the branch into trunk? If you really want a squashed commit (you'll lose the history?) there's one at thanatos@rackspace-pagination-squished. (1a8b287)

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 24, 2014

Member

@thanatos That's a standard workflow for our project. It keeps history cleaner.

Member

Kami commented Jan 24, 2014

@thanatos That's a standard workflow for our project. It keeps history cleaner.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jan 24, 2014

Member

Patch merged into trunk. Thanks pull request can be closed now.

Thanks.

Member

Kami commented Jan 24, 2014

Patch merged into trunk. Thanks pull request can be closed now.

Thanks.

@thanatos thanatos closed this Jan 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment