LIBCLOUD-504: Add support for records with multiple values such as MX/...#237
Closed
cderamus wants to merge 2 commits intoapache:trunkfrom
DivvyCloud:LIBCLOUD-504_Add_Multi_Record_Support
Closed
LIBCLOUD-504: Add support for records with multiple values such as MX/...#237cderamus wants to merge 2 commits intoapache:trunkfrom DivvyCloud:LIBCLOUD-504_Add_Multi_Record_Support
cderamus wants to merge 2 commits intoapache:trunkfrom
DivvyCloud:LIBCLOUD-504_Add_Multi_Record_Support
Conversation
…MX/NS records as well an additional fixture and test.
Member
|
I was actually thinking about that in the past. If we want to make it consistent across all the drivers, each value should be exposed as a separate record (that's how it currently works with other drivers). For example:
|
Contributor
Author
|
Gotcha, that makes sense. I'll update this shortly. |
… MX records to be broken out into separate Record objects.
Member
|
I've merged changes to trunk, thanks. While I was at it, I also made some changes to parse / handle SRV records better. |
Contributor
Author
|
Ah great call, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...NS records as well an additional fixture and test.