Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-504: Add support for records with multiple values such as MX/... #237

Closed
wants to merge 2 commits into from

Conversation

@cderamus
Copy link
Contributor

cderamus commented Feb 2, 2014

...NS records as well an additional fixture and test.

…MX/NS records as well an additional fixture and test.
@Kami
Copy link
Member

Kami commented Feb 2, 2014

I was actually thinking about that in the past.

If we want to make it consistent across all the drivers, each value should be exposed as a separate record (that's how it currently works with other drivers).

For example:

  • record 1: name=None, value=ASPMX.L.GOOGLE.COM., extra['priority']=1
  • record 2: name=None, value=ALT1.ASPMX.L.GOOGLE.COM., extra['priority']=5
  • etc.
@cderamus
Copy link
Contributor Author

cderamus commented Feb 2, 2014

Gotcha, that makes sense. I'll update this shortly.

… MX records to be broken out into separate Record objects.
@Kami
Copy link
Member

Kami commented Feb 5, 2014

I've merged changes to trunk, thanks.

While I was at it, I also made some changes to parse / handle SRV records better.

@cderamus
Copy link
Contributor Author

cderamus commented Feb 5, 2014

Ah great call, thanks!

@cderamus cderamus closed this Feb 5, 2014
@cderamus cderamus deleted the DivvyCloud:LIBCLOUD-504_Add_Multi_Record_Support branch Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.