Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-508: Add support for registering Amazon Machine Images using S3... #241

Closed
wants to merge 2 commits into from
Closed

LIBCLOUD-508: Add support for registering Amazon Machine Images using S3... #241

wants to merge 2 commits into from

Conversation

cderamus
Copy link
Contributor

@cderamus cderamus commented Feb 2, 2014

... manifests or Snapshots. New tests are also included.

… S3 manifests or Snapshots. New tests are also included.
block_device_mapping))

if kernel_id is not None:
params["KernelId"] = kernel_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quotes everywhere for consistency.

@Kami
Copy link
Member

Kami commented Feb 2, 2014

Looks good. Merged into trunk.

Thanks,

@asfgit asfgit closed this in 834a9ea Feb 2, 2014
@cderamus cderamus deleted the LIBCLOUD-508_Add_Register_Image_Support branch February 2, 2014 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants