Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBCLOUD-508: Add support for registering Amazon Machine Images using S3... #241

Closed
wants to merge 2 commits into from

Conversation

@cderamus
Copy link
Contributor

cderamus commented Feb 2, 2014

... manifests or Snapshots. New tests are also included.

… S3 manifests or Snapshots. New tests are also included.
block_device_mapping))

if kernel_id is not None:
params["KernelId"] = kernel_id

This comment has been minimized.

@Kami

Kami Feb 2, 2014 Member

Please use single quotes everywhere for consistency.

:param name: The name for the AMI being registered
:type name: ``str``
:param description: The description of the AMI

This comment has been minimized.

@Kami

Kami Feb 2, 2014 Member

It would also be good to add (optional) next to the arguments which are optional.

@Kami
Copy link
Member

Kami commented Feb 2, 2014

Looks good. Merged into trunk.

Thanks,

@asfgit asfgit closed this in 834a9ea Feb 2, 2014
@cderamus cderamus deleted the DivvyCloud:LIBCLOUD-508_Add_Register_Image_Support branch Feb 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.