New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CloudStack NodeStates for Stopped/Stopping #246

Closed
wants to merge 13 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@cderamus
Contributor

cderamus commented Feb 6, 2014

No description provided.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 7, 2014

Member

We've discussed this on the IRC with @cderamus yesterday.

I think we should also map stopping and expunging to pending instead of terminated. The reason for that is that not all the operations are available until the node is fully stopped (stopped state).

This means that currently your code might fail if you wait until node.state == stopped because node might actually still be in stopping state.

Member

Kami commented Feb 7, 2014

We've discussed this on the IRC with @cderamus yesterday.

I think we should also map stopping and expunging to pending instead of terminated. The reason for that is that not all the operations are available until the node is fully stopped (stopped state).

This means that currently your code might fail if you wait until node.state == stopped because node might actually still be in stopping state.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Feb 7, 2014

Member

I've merged the changes mentioned above and merged this into trunk.

Thanks.

Member

Kami commented Feb 7, 2014

I've merged the changes mentioned above and merged this into trunk.

Thanks.

@cderamus cderamus closed this Feb 7, 2014

@cderamus cderamus deleted the DivvyCloud:Update_CloudStack_Node_States branch Feb 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment