-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIBCLOUD-526] Add CloudStackProject class and tests, and ability to create node with project. #257
Conversation
…fering on node creation.
…ect and disk offering on node creation. Add tests.
Class representing a CloudStack Project. | ||
""" | ||
|
||
def __init__(self, displaytext, name, id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, displaytext
should be display_text
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think, arguments should be defined in a different order. So:
def __init__(self, id, name display_text, driver, extra=None)
Lint step appears to be failing - https://travis-ci.org/apache/libcloud/jobs/20244959 |
I've added some comments. Besides that, PR looks good to me. |
there is some new indentation in the list_volumes and ex_list_port_forwarding methods that are most likely breaking pep8. |
…ect and disk offering on node creation. Add tests.
OK, I've made the suggested changes. My IDE changed some indentation which caused flake8 to fail. "displaytext" is used on other types in this driver (e.g. CloudStackNetwork) but I have made the change to "display_text" as suggested. Thank you. |
…ect and disk offering on node creation. Add tests.
…ect and disk offering on node creation. Add tests.
Fixed a couple of other indentation issues that cropped up under the docs phase. |
Merged into trunk. Thanks. |
https://issues.apache.org/jira/browse/LIBCLOUD-526