Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add `ex_set_volume_auto_delete` to the GCE driver. #264
Ha, interesting. For both suggestions, that's what I would normally have done. But the previous function declaration (
Would a second pull request to modify the
Thanks for the quick feedback, will update.
@franckcuny Yeah, a second pull request would be much appreciated.
An sadly we currently only enforce things like this manually during the PR review so it's kinda easy to miss it. The good news is that we are working on an automatic system for checking that the driver and methods comply to the base API :)
Looks good to me
I'm a bit confused about the conversation regarding a second pull request for detach_volume. The signature for detach volume is like it is because the base API doesn't allow for the node to be set as a positional argument. So, even though volume.detach() won't actually work for GCE, adding a positional argument for node to detach_volume would cause volume.detach() to error out.