Skip to content

Add support for Google DNS API.#269

Closed
fcuny wants to merge 1 commit intoapache:trunkfrom
fcuny:google-dns
Closed

Add support for Google DNS API.#269
fcuny wants to merge 1 commit intoapache:trunkfrom
fcuny:google-dns

Conversation

@fcuny
Copy link

@fcuny fcuny commented Mar 30, 2014

Google recently added a new API for DNS management. This new driver
implement simple operations to create and view zones and records.

I still need to add a few more tests and probably add a bunch of things into the 'extra' for records and zones.

I'm also not familiar with other DNS drivers, so a few things might be wrong or should be done differently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explicitly declare all the supports arguments instead of (ab)using kwargs?

@Kami
Copy link
Member

Kami commented Apr 7, 2014

@franckcuny Thanks for addressing the comments.

I'll do another review shortly and let you know if I encounter any more issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing - to prevent accidental bugs, please always use parenthesis around format string arguments.

@Kami
Copy link
Member

Kami commented Apr 7, 2014

Besides some minor style and consistency issues, it looks good to me.

@Kami
Copy link
Member

Kami commented Apr 7, 2014

Please also sync this branch with trunk so Travis build won't fail anymore.

Google recently added a new API for DNS management. This new driver
implement simple operations to create and view zones and records.
@erjohnso
Copy link
Contributor

@Kami, @franckcuny - is this good to go? I am intending to add an Ansible module and would love to take advantage of this work. :)

@Kami
Copy link
Member

Kami commented Apr 28, 2014

@erjohnso Sorry for the delay. I've just merged those changes into trunk.

@erjohnso
Copy link
Contributor

@Kami thank you sir!

@asfgit asfgit closed this in 8654313 Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants