Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-535] Add EbsOptimized parameter to create_node() method #272

Closed
wants to merge 4 commits into from

Conversation

@zerthimon
Copy link
Contributor

@zerthimon zerthimon commented Apr 4, 2014

Add EbsOptimized parameter to create_node() method of BaseEC2NodeDriver in ec2.py driver

of BaseEC2NodeDriver in ec2.py driver
@@ -1430,6 +1430,9 @@ def create_node(self, **kwargs):
else:
params['IamInstanceProfile.Name'] = kwargs['ex_iamprofile']

if 'EbsOptimized' in kwargs:

This comment has been minimized.

@Kami

Kami Apr 6, 2014
Member

This should be an extension argument (prefixed with ex_). For consistency, please also use underscore separated name, so ex_ebs_optimized.

@zerthimon
Copy link
Contributor Author

@zerthimon zerthimon commented Apr 7, 2014

Pushed requested changes.

zerthimon added 2 commits Apr 4, 2014
of BaseEC2NodeDriver in ec2.py driver

[LIBCLOUD-535] Fix parameter name add documentation
…github.com/zerthimon/libcloud into LIBCLOUD-535_create-EBS-Optimized-instance
@Kami
Copy link
Member

@Kami Kami commented Apr 7, 2014

Merged into trunk.

Thanks.

@asfgit asfgit closed this in 5028463 Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.