New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecated flag to a size for GCE nodes. #276

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@bassdread
Contributor

bassdread commented Apr 10, 2014

Currently sizes are flagged as deprecated in the Google GCE API

'deprecated': {'state': 'OBSOLETE', 'replacement': 'https://www.googleapis.com/compute/v1/projects/clever-span-499/zones/us-central1-a/machineTypes/n1-highmem-4'}

But there is no field to indicate this on the returned size.

The code below attaches a 'deprecated' value to 'extra' so it's possible to identify deprecated sizes.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Apr 23, 2014

Member

Sorry for the delay.

I've fixed the code (it was referencing undefined machine_type variable) and merged changes into trunk. Thanks.

Member

Kami commented Apr 23, 2014

Sorry for the delay.

I've fixed the code (it was referencing undefined machine_type variable) and merged changes into trunk. Thanks.

@asfgit asfgit closed this in de8e4ce Apr 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment