[LIBCLOUD-537] Added support for generic image management at Rackspace and EC2 #277
Conversation
|
Fixed docstring errors |
|
Sorry for the delay, I will look some time in the next couple of days. |
|
No worries I'm just running off of my branch. |
|
Also noticing we need to add a generic state attribute to NodeImage in compute/base.py and have a statemap for NodeImage in compute/types.py. I'm primarily working to EC2/Rackspace so once we get an initial patch in place I can extend that to support a state on NodeImage for at least those drivers but specify it as None by default so it doesn't interfere with other drivers. |
| :param description: description for new image. | ||
| :type name: ``description`` | ||
|
|
||
| :param reboot: description for new image. |
There was a problem hiding this comment.
What does the reboot argument does?
Also, is this available across all the providers or is it provider specific?
There was a problem hiding this comment.
For Amazon it makes sure the instance reboots in order to guarantee file system integrity. I looked into Amazon, Rackspace, Google, and even Azure. It does appear that this is an Amazon specific argument and it is not needed as the default should be okay. I will remove it from the base and put back the original implementation in the ec2.py file.
|
Is there anything specific I need to do to trigger another Travis CI build? |
|
Nope, it should be triggered manually but it might take a while. |
|
Sorry for the delay, I've merged your changes into trunk. I've noticed you manually created the supported methods rst file. Those files |
I was planning to take care of GCE in this first push as well. However, Google presents an interesting challenge with their persistent disk model and their use of the snapshot and image terms. We could use snapshots as a replacement for images. However, this would then limit our ability to use the default images provided by Google. It seems like we actually need a factory for evaluating both the images and snapshots in order to fold in GCE. I completed the _supported_methods_image_management.rst as well in case we want to include it in the documentation. I did submit an email regarding this effort to the dev mail list but I didn't hear anything back so I just went ahead and made the change.