Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
The hostname should be fullyQualifiedDomainName instead of hostname #280
If you go to the softlayer panel and check the hosts you will see the names are equal to the fullyQualifiedDomainName and not the hostname, so it would be logical for me to use host['fullyQualifiedDomainName'] instead. Howhever if you really don`t want to do this then I would suggest putting the field into extra['fullyQualifiedDomainName'] instead of extra['hostname'].
What do you think?
Hi @RoelVanNyen, I find this fix quite problematic. Imagine the following scenario:
You create a node by:
Then, later you want to find this node by name:
Doesn't it break the generic purpose of libcloud where you will certainly have to "if conn is the SoftLayer" then check node.name == id + "example.com".
I suggest that the name is still the original created name while you will add extra attribute fullyQualifiedDomainName instead.