[LIBCLOUD-536] Add support for the Outscale SAS cloud. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| message = "Attribute %s not implemented" % (attribute) | ||
| raise NotImplementedError(message) | ||
|
|
||
| return super(OutscaleNodeDriver, self).ex_modify_instance_attribute( |
There was a problem hiding this comment.
Looks good, but for readability purposes please use keyword arguments everywhere.
There was a problem hiding this comment.
I though about this but if I start passing disable_api_termination and friend as keywords the OutscaleNodeDriver will differs from the EC2NodeDriver and polymorphism wont work.
Are you sure it's not an issue ?
There was a problem hiding this comment.
Yeah, I don't think this should be an issue.
This commit introduce the Outscale SAS cloud an european cloud provider featuring an EC2 compatible API. Special care have been taken to leave room for Outscale INC an US based cloud using the same infrastructure but governed by US laws. Signed-off-by: Benoît Canet <benoit@irqsave.net>
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce the Outscale SAS cloud an european cloud provider
featuring an EC2 compatible API.
Special care have been taken to leave room for Outscale INC an US based cloud
using the same infrastructure but governed by US laws.
Signed-off-by: Benoît Canet benoit@irqsave.net