Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-536] Add support for the Outscale SAS cloud. #285

Closed
wants to merge 1 commit into from
Closed

[LIBCLOUD-536] Add support for the Outscale SAS cloud. #285

wants to merge 1 commit into from

Conversation

benoit-canet
Copy link

This commit introduce the Outscale SAS cloud an european cloud provider
featuring an EC2 compatible API.

Special care have been taken to leave room for Outscale INC an US based cloud
using the same infrastructure but governed by US laws.

Signed-off-by: Benoît Canet benoit@irqsave.net

message = "Attribute %s not implemented" % (attribute)
raise NotImplementedError(message)

return super(OutscaleNodeDriver, self).ex_modify_instance_attribute(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for readability purposes please use keyword arguments everywhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though about this but if I start passing disable_api_termination and friend as keywords the OutscaleNodeDriver will differs from the EC2NodeDriver and polymorphism wont work.
Are you sure it's not an issue ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think this should be an issue.

This commit introduce the Outscale SAS cloud an european cloud provider
featuring an EC2 compatible API.

Special care have been taken to leave room for Outscale INC an US based cloud
using the same infrastructure but governed by US laws.

Signed-off-by: Benoît Canet <benoit@irqsave.net>
@asfgit asfgit closed this in 0a049c4 May 7, 2014
@Kami
Copy link
Member

Kami commented May 8, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants