[LIBCLOUD-547] linode.py labels too long with name use linode id instead #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone.id changed to zone in lines 433 and 434 Modified: libcloud/dns/drivers/zerigo.py
Restored original: libcloud/dns/drivers/zerigo.py
|
Sorry for the delay, I'll review the pull request now. |
| # Use the linode id as the name can be up to 63 chars and the labels | ||
| # are limited to 48 chars | ||
| label = { | ||
| "lconfig": "[%s] Configuration Profile" % linode["id"], |
There was a problem hiding this comment.
This looks good, although if we wanted to be sure that labels are never longer we could truncate it in this case (`...[:48]).
|
@earthgecko I wanted to apply your patch into trunk, but I'm getting conflicts. Can you please sync you branch with upstream trunk and squash all the commits? |
|
I went ahead and manually merged the changes into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using linode["id"] for labels and the labels step needed to be moved down to after the linode object exists so that the id can be used.
Apologies about the old commit messages could not get rid of them rebased and all but the diff is sound.