[LIBCLOUD-555] Added support for openstack compute availability zone #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syndicut
added a commit
to syndicut/salt
that referenced
this pull request
May 15, 2014
This feature depends on this feature in apache/libcloud#295: https://issues.apache.org/jira/browse/LIBCLOUD-555
| @@ -1318,6 +1318,9 @@ def _create_args_to_params(self, node, **kwargs): | |||
| {})) | |||
| } | |||
|
|
|||
| if 'availability_zone' in kwargs: | |||
| server_params['availability_zone'] = kwargs['availability_zone'] | |||
There was a problem hiding this comment.
This is an extension param so please prefix it with ex_:
if 'ex_availability_zone' in kwargs:
server_params['availability_zone'] = kwargs['ex_availability_zone']There was a problem hiding this comment.
Please also update create_node docstring and document this kwarg there - https://github.com/syndicut/libcloud/blob/LIBCLOUD-555_openstack_availability_zone/libcloud/compute/drivers/openstack.py#L1218
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/LIBCLOUD-555