[Libcloud-556] Azure Compute Driver Support #305

baldwinSPC · 2014-06-03T12:14:05Z

We have completed support for the Azure compute driver. This adds support for the core compute driver functions against Azure. The JIRA ticket can be found here:

https://issues.apache.org/jira/browse/LIBCLOUD-556?jql=project%20%3D%20LIBCLOUD

Let me know if there are any issues or if it can be accepted or not.

Thanks.
-matt

Kami · 2014-06-05T09:52:41Z

libcloud/compute/drivers/azure.py

+from xml.sax.saxutils import escape as xml_escape
+from httplib import (HTTPSConnection)
+
+if sys.version_info < (3,):


You should use libcloud.utils.urlquote and libcloud.utils.urlunquote which handles this for you.

Kami · 2014-06-05T09:58:54Z

Thanks!

Just added some quick comments. Will do a more complete review later on.

baldwinSPC · 2014-06-06T03:28:46Z

Thanks Tomaz. I'll begin to address these items.

-matt

On Thu, Jun 5, 2014 at 2:58 AM, Tomaz Muraus notifications@github.com
wrote:

Thanks!

Just added some quick comments. Will do a more complete review later on.

—
Reply to this email directly or view it on GitHub
#305 (comment).

jclark360 · 2014-06-24T11:54:33Z

Looking forward to seeing this in a release

baldwinSPC · 2014-07-01T18:15:31Z

I'm back from being out of town on business for too many weeks and have turned to squashing these items. Should have something shortly.

phamnamlong · 2014-09-23T01:48:29Z

Is there anyone following up with the merge of this pull request ?

baldwinSPC · 2014-09-24T04:31:00Z

Hi Pham:

Yes, we're currently re-working this compute driver to utilize ET versus
how it is currently implemented. Unfortunately, I've been delayed in being
able to return to this. I'm hoping I will have more time in mid-October to
pick this back up and knock it out.

Thanks.
-matt

On Mon, Sep 22, 2014 at 6:48 PM, Pham Nam Long notifications@github.com
wrote:

Is there anyone following up with the merge of this pull request ?

—
Reply to this email directly or view it on GitHub
#305 (comment).

azurecoder · 2014-09-24T07:51:34Z

Started the ET support this week Matt - will commit this weekend and pickup with you.

baldwinSPC · 2014-09-24T19:42:12Z

Sweet. Thanks Richard!

On Wed, Sep 24, 2014 at 12:51 AM, Richard Conway notifications@github.com
wrote:

Started the ET support this week Matt - will commit this weekend and
pickup with you.

—
Reply to this email directly or view it on GitHub
#305 (comment).

davidcrossland · 2014-10-03T09:24:26Z

Can you take a look at the PR now - we've updated the xml serialization to use element tree as advised as can successfully run all compute functions and all unit tests pass

baldwinSPC · 2014-10-09T00:26:16Z

Thanks David. I'll review this over the weekend. Then we can go from there.

On Fri, Oct 3, 2014 at 2:24 AM, davidcrossland notifications@github.com
wrote:

Can you take a look at the PR now - we've updated the xml serialization to
use element tree as advised as can successfully run all compute functions
and all unit tests pass

—
Reply to this email directly or view it on GitHub
#305 (comment).

bennettaur · 2014-10-29T16:00:25Z

I've been working on a branch of this, adding in some functionality I needed for a project. You can see my branch here: https://github.com/SecurityCompass/libcloud/commits/LIBCLOUD-556_azure_compute_driver_rebased

I've added some functionality like displaying custom VM images along with the azure provided ones, creating nodes using custom VMs, and using NodeSize, NodeLocation, and NodeImage for the arguments to create node. I also rebased this branch on almost the latest trunk and fixed some issues there.

It looks like there might be some overlap in some of the current efforts and I imagine the easiest approach is for me to pull in the changes and then open a PR back to this branch. Is anything else being actively worked on that I should wait for?

azurecoder · 2014-11-01T14:10:55Z

Hi Michael – we did a recent commit to add ET. We need this functionality too as does Matt B. We’ve got a full test coverage currently. Please feel free to pull in the changes. We’re still waiting for this branch to be merged as it happens.

All the best,

Richard Conway
Head of Product Development | Elastacloud Limited | Windows Azure MVP and Insider
T. 0208 530 3999 (office) | 07590333990 (mobile)
W. Web Sitehttp://www.elastacloud.com/ | My Linked Inapplewebdata://D40E0893-DB28-4B52-94DE-FC6823F51ADC/uk.linkedin.com/in/richardelastacloud/ | My Bloghttp://azurecoder.azurewebsites.net/ | My Twitterapplewebdata://D40E0893-DB28-4B52-94DE-FC6823F51ADC/twitter.com/azurecoder | UK Azure User Group Twitterapplewebdata://D40E0893-DB28-4B52-94DE-FC6823F51ADC/twitter.com/ukwaug

From: Michael Bennett [mailto:notifications@github.com]
Sent: Wednesday, October 29, 2014 4:00 PM
To: apache/libcloud
Cc: Richard Conway
Subject: Re: [libcloud] [Libcloud-556] Azure Compute Driver Support (#305)

I've working on a branch of this, adding in some functionality I needed for a project. You can see my branch here: https://github.com/SecurityCompass/libcloud/commits/LIBCLOUD-556_azure_compute_driver_rebased

I've added some functionality like displaying custom VM images along with the azure provided ones, creating nodes using custom VMs, and using NodeSize, NodeLocation, and NodeImage for the arguments to create node. I also rebased this branch on almost the latest trunk and fixed some issues there.

It looks like there might be some overlap in some of the current efforts and I imagine the easiest approach is for me to pull in the changes and then open a PR back to this branch. Is anything else being actively worked on that I should wait for?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/305#issuecomment-60950727.

bennettaur · 2014-11-24T15:04:24Z

Hey so I created this pull request against your branch: baldwinSPC#3

I merged in the update for XML generation and also added support for handling 307 responses from Azure (before the driver had 307 as a successful call but threw an exception when handling it). I was getting these during testing which was getting in the way.

I've also rebased this onto apache's trunk which makes the branch able to be automatically merged so hopefully we can get this merged (I checked that it indeed can be) in soon :)

baldwinSPC · 2014-12-05T16:54:25Z

Hey Michael:

Just updating the thread. Thanks for sending this over. I see it and will
have a chance to work on it over this weekend. I was overseas when you sent
this over originally.

Thanks.
-matt

On Mon, Nov 24, 2014 at 7:04 AM, Michael Bennett notifications@github.com
wrote:

Hey so I created this pull request against your branch: baldwinSPC#3
baldwinSPC#3

I merged in the update for XML generation and also added support for
handling 307 responses from Azure (before the driver had 307 as a
successful call but threw an exception when handling it). I was getting
these during testing which was getting in the way.

I've also rebased this onto apache's trunk which makes the branch able to
be automatically merged so hopefully we can get this merged (I checked that
it indeed can be) in soon :)

—
Reply to this email directly or view it on GitHub
#305 (comment).

sebgoa · 2015-02-27T14:59:00Z

Hi folks, can you rebase and squash all commits. If it contains tests and passes the travis builds, I am happy to merge it.

sebgoa · 2015-02-27T15:00:59Z

@Kami can you check this. It's large...

bennettaur · 2015-02-27T15:30:53Z

There is still a pending pull request on their branch here: baldwinSPC#3 which included a rebase. For the branch waiting to be merged (https://github.com/SecurityCompass/libcloud/tree/LIBCLOUD-556_azure_compute_driver_rebased) it looks like it can still be merged automatically (just checked) so it's a matter of whether it passes a travis build.

I can either create a new PR for my branch and address any issues there, or we can stick with this PR

sebgoa · 2015-02-27T15:34:51Z

@bennettaur in order to give credits to the right folks, it'd be better if you created another PR with your work. We can merge that, and then folks can patch it with new PR.

baldwinSPC · 2015-02-27T15:47:25Z

Sorry for the other PR being stuck. I have no time to commit to it at this
point due to way to many work obligations. How would you like to move
forward?
On Feb 27, 2015 7:34 AM, "runseb" notifications@github.com wrote:

@bennettaur https://github.com/bennettaur in order to give credits to
the right folks, it'd be better if you created another PR with your work.
We can merge that, and then folks can patch it with new PR.

—
Reply to this email directly or view it on GitHub
#305 (comment).

sebgoa · 2015-02-27T16:11:46Z

@bennettaur @baldwinSPC so you have a pending PR on a fork of libcloud. In any case PR from different individuals should come straight upstream so we can properly keep track or authorship. So tell me what I can merge in libcloud upstream right now, and I will do so. Then you can patch this upstream driver. Does that make sense ?

azurecoder · 2015-02-27T17:06:59Z

@davidcrossland and I did quite a bit of initial work on this but I think all code is in @baldwinSPC branch so a single PR from there should suffice.

…_driver_rebased Support for Virtual Machine Images and handling of Temp Redirects

baldwinSPC · 2015-02-27T17:29:59Z

I just merged your PR @bennettaur into the branch. @Runseb PR 305 is
currently being re-validated by Travis. Will this be good for you @Runseb?

On Fri, Feb 27, 2015 at 9:07 AM, Richard Conway notifications@github.com
wrote:

@davidcrossland https://github.com/davidcrossland and I did quite a bit
of initial work on this but I think all code is in @baldwinSPC
https://github.com/baldwinSPC branch so a single PR from there should
suffice.

—
Reply to this email directly or view it on GitHub
#305 (comment).

sebgoa · 2015-02-27T17:35:38Z

Let me check with @Kami cause we may have an authorship tracking problem here.

baldwinSPC · 2015-02-27T18:01:10Z

OK, thanks @Runseb I believe the current PR has all authors in it, who are,
if I'm not mistaken:

@bennettaur
@davidcrossland
@azurecoder
@baldwinSPC
@baldwinmathew

-matt

On Fri, Feb 27, 2015 at 9:35 AM, runseb notifications@github.com wrote:

Let me check with @Kami https://github.com/Kami cause we may have an
authorship tracking problem here.

—
Reply to this email directly or view it on GitHub
#305 (comment).

Kami · 2015-04-04T21:53:13Z

Sorry everyone for the delay. The pull request and the patch itself is just big and I'm busy and had problems finding a big enough chunk of time which would allow me to thoroughly review the changes.

I finally started working on it today though. I created a new branch based on this pull request where I will push any cleanup or changes which are needed (I will open a new PR shortly). Hopefully patch will finally land in trunk soon.

Kami · 2015-04-05T12:20:50Z

Lets continue in #499.

Closes #305 Closes #499

Kami reviewed Jun 5, 2014
View reviewed changes

Merge pull request #3 from SecurityCompass/LIBCLOUD-556_azure_compute…

33e0090

…_driver_rebased Support for Virtual Machine Images and handling of Temp Redirects

Kami mentioned this pull request Apr 5, 2015

Azure Compute Driver #499

Closed

asfgit merged commit 33e0090 into apache:trunk Apr 6, 2015

asfgit pushed a commit that referenced this pull request Apr 6, 2015

Update changes.

1bef164

Closes #305 Closes #499

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Libcloud-556] Azure Compute Driver Support #305

[Libcloud-556] Azure Compute Driver Support #305

baldwinSPC commented Jun 3, 2014

Kami Jun 5, 2014

Kami commented Jun 5, 2014

baldwinSPC commented Jun 6, 2014

jclark360 commented Jun 24, 2014

baldwinSPC commented Jul 1, 2014

phamnamlong commented Sep 23, 2014

baldwinSPC commented Sep 24, 2014

azurecoder commented Sep 24, 2014

baldwinSPC commented Sep 24, 2014

davidcrossland commented Oct 3, 2014

baldwinSPC commented Oct 9, 2014

bennettaur commented Oct 29, 2014

azurecoder commented Nov 1, 2014

bennettaur commented Nov 24, 2014

baldwinSPC commented Dec 5, 2014

sebgoa commented Feb 27, 2015

sebgoa commented Feb 27, 2015

bennettaur commented Feb 27, 2015

sebgoa commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

sebgoa commented Feb 27, 2015

azurecoder commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

sebgoa commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

Kami commented Apr 4, 2015

Kami commented Apr 5, 2015

[Libcloud-556] Azure Compute Driver Support #305

[Libcloud-556] Azure Compute Driver Support #305

Conversation

baldwinSPC commented Jun 3, 2014

Kami Jun 5, 2014

Choose a reason for hiding this comment

Kami commented Jun 5, 2014

baldwinSPC commented Jun 6, 2014

jclark360 commented Jun 24, 2014

baldwinSPC commented Jul 1, 2014

phamnamlong commented Sep 23, 2014

baldwinSPC commented Sep 24, 2014

azurecoder commented Sep 24, 2014

baldwinSPC commented Sep 24, 2014

davidcrossland commented Oct 3, 2014

baldwinSPC commented Oct 9, 2014

bennettaur commented Oct 29, 2014

azurecoder commented Nov 1, 2014

bennettaur commented Nov 24, 2014

baldwinSPC commented Dec 5, 2014

sebgoa commented Feb 27, 2015

sebgoa commented Feb 27, 2015

bennettaur commented Feb 27, 2015

sebgoa commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

sebgoa commented Feb 27, 2015

azurecoder commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

sebgoa commented Feb 27, 2015

baldwinSPC commented Feb 27, 2015

Kami commented Apr 4, 2015

Kami commented Apr 5, 2015