New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-573] Update 'CA_CERTS_PATH' to look for updated MacOS X Homebrew location #309

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
Show outdated Hide outdated libcloud/security.py
# homebrew: curl-ca-bundle
'/usr/local/opt/curl-ca-bundle/share/ca-bundle.crt',
# homebrew: openssl
'/usr/local/etc/openssl/cert.pem',

This comment has been minimized.

@Kami

Kami Jun 4, 2014

Member

Libcloud tries the paths in the way they are defined and the first bundle which is found is used.

It seems like /usr/local/etc/openssl/cert.pem is preferred since it's generated from a key chain, but we should probably still keep path to curl-ca-bundle path there for backward compatibility reasons (not all users might have installed openssl formula, etc.).

We can simply decrease the priority of curl-ca-bundle and move it after the openssl bundle path.

@Kami

Kami Jun 4, 2014

Member

Libcloud tries the paths in the way they are defined and the first bundle which is found is used.

It seems like /usr/local/etc/openssl/cert.pem is preferred since it's generated from a key chain, but we should probably still keep path to curl-ca-bundle path there for backward compatibility reasons (not all users might have installed openssl formula, etc.).

We can simply decrease the priority of curl-ca-bundle and move it after the openssl bundle path.

@paparomeo

This comment has been minimized.

Show comment
Hide comment
@paparomeo

paparomeo Jun 4, 2014

Contributor

@Kami: agreed. Pull request updated.

Contributor

paparomeo commented Jun 4, 2014

@Kami: agreed. Pull request updated.

@asfgit asfgit closed this in ffb63c2 Jun 5, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 5, 2014

Member

Merged into trunk.

Thanks!

Member

Kami commented Jun 5, 2014

Merged into trunk.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment