New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra info to images for EC2 driver #31

Closed
wants to merge 2 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@JuanCarlosM

JuanCarlosM commented Oct 19, 2011

No description provided.

@@ -266,7 +266,7 @@ class NodeImage(object):
def __repr__(self):
return (('<NodeImage: id=%s, name=%s, driver=%s ...>')
% (self.id, self.name, self.driver.name))
% (self.id, self.name, self.driver.name, self.extra))

This comment has been minimized.

@Kami

Kami Oct 19, 2011

Member

This will throw an exception since there are only three placeholders in the string.

@Kami

Kami Oct 19, 2011

Member

This will throw an exception since there are only three placeholders in the string.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 21, 2011

Member

I have merged your patch (with some changes) into trunk in 1187584.

Next time please make sure pep8 tool returns no warnings for modified files.

Also, can you please close this pull request now (we can't do it)?

Member

Kami commented Oct 21, 2011

I have merged your patch (with some changes) into trunk in 1187584.

Next time please make sure pep8 tool returns no warnings for modified files.

Also, can you please close this pull request now (we can't do it)?

@JuanCarlosM

This comment has been minimized.

Show comment
Hide comment
@JuanCarlosM

JuanCarlosM Oct 25, 2011

ok, thank you. I Hope to contribute more in the future, and I yes, I will check warnings :)

JuanCarlosM commented Oct 25, 2011

ok, thank you. I Hope to contribute more in the future, and I yes, I will check warnings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment