Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd extra info to images for EC2 driver #31
Conversation
JuanCarlosM
added some commits
Oct 19, 2011
Kami
reviewed
Oct 19, 2011
| @@ -266,7 +266,7 @@ class NodeImage(object): | ||
| def __repr__(self): | ||
| return (('<NodeImage: id=%s, name=%s, driver=%s ...>') | ||
| % (self.id, self.name, self.driver.name)) | ||
| % (self.id, self.name, self.driver.name, self.extra)) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Oct 19, 2011
Member
This will throw an exception since there are only three placeholders in the string.
Kami
Oct 19, 2011
Member
This will throw an exception since there are only three placeholders in the string.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kami
Oct 21, 2011
Member
I have merged your patch (with some changes) into trunk in 1187584.
Next time please make sure pep8 tool returns no warnings for modified files.
Also, can you please close this pull request now (we can't do it)?
|
I have merged your patch (with some changes) into trunk in 1187584. Next time please make sure Also, can you please close this pull request now (we can't do it)? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
JuanCarlosM
Oct 25, 2011
ok, thank you. I Hope to contribute more in the future, and I yes, I will check warnings :)
JuanCarlosM
commented
Oct 25, 2011
|
ok, thank you. I Hope to contribute more in the future, and I yes, I will check warnings :) |
JuanCarlosM commentedOct 19, 2011
No description provided.