Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-575] Adding all_tenats parameter for list_nodes in Openstack #312

Closed
wants to merge 2 commits into from

Conversation

@zestrada
Copy link
Contributor

zestrada commented Jun 9, 2014

Creating a pull request per commit discussion. Tests forthcoming.

@zestrada

This comment has been minimized.

Copy link
Owner Author

zestrada commented on 55a84c6 Jun 9, 2014

I originally had something like "params= {'all_tenants': int(all_tenants)}" but discovered that my version of openstack keys off of the existence of the parameter

This comment has been minimized.

Copy link

Kami replied Jun 9, 2014

Also, please feel free to open a pull request for this change, even if it's unfinished.

This way it's easier for us to add comments.

@Kami

This comment has been minimized.

Copy link

Kami commented on libcloud/compute/drivers/openstack.py in 55a84c6 Jun 9, 2014

This is an extension argument so it should be prefixed with ex_ - ex_all_tenants.

It would also be good to add a docstring which explains what this argument does, e.g.:

:param ex_all_tenants: Include nodes for all the tenants. Note: You need to use tenant with admin privileges for this functionality to work.
@asfgit asfgit closed this in 93c3898 Jun 11, 2014
@Kami
Copy link
Member

Kami commented Jun 11, 2014

Squashed the commits and merged change into trunk.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.