New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcloud 574 routes and route tables #313

Closed
wants to merge 16 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@zerthimon
Contributor

zerthimon commented Jun 10, 2014

Support for EC2 Route Tables and Routes.

@zerthimon

This comment has been minimized.

Show comment
Hide comment
@zerthimon

zerthimon Jun 10, 2014

Contributor

@Kami is there anything else I should do here ?

Contributor

zerthimon commented Jun 10, 2014

@Kami is there anything else I should do here ?

@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
@Kami

View changes

Show outdated Hide outdated libcloud/compute/drivers/ec2.py Outdated
@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 11, 2014

Member

Ok, reviewed the whole pull request.

There are some minor issues left, but it mostly looks good. Next step would be adding tests for this new functionality. Let us know if you need help with that.

Member

Kami commented Jun 11, 2014

Ok, reviewed the whole pull request.

There are some minor issues left, but it mostly looks good. Next step would be adding tests for this new functionality. Let us know if you need help with that.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 12, 2014

Member

@zerthimon Let me know once those issues have been addressed and I will get it merged into trunk.

Member

Kami commented Jun 12, 2014

@zerthimon Let me know once those issues have been addressed and I will get it merged into trunk.

@zerthimon

This comment has been minimized.

Show comment
Hide comment
@zerthimon

zerthimon Jun 16, 2014

Contributor

@Kami

Fixed issues that you found during code review.
Also changed ex_create_route() and ex_replace_route() to accept objects and extract IDs, instead of passing IDs as strings.

Contributor

zerthimon commented Jun 16, 2014

@Kami

Fixed issues that you found during code review.
Also changed ex_create_route() and ex_replace_route() to accept objects and extract IDs, instead of passing IDs as strings.

@asfgit asfgit closed this in fcd353d Jun 16, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jun 16, 2014

Member

Merged into trunk. Thanks.

Member

Kami commented Jun 16, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment