Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-580] node filters for ec2 driver #320

Closed
wants to merge 2 commits into from
Closed

[LIBCLOUD-580] node filters for ec2 driver #320

wants to merge 2 commits into from

Conversation

zerthimon
Copy link
Contributor

@zerthimon zerthimon commented Jun 20, 2014

Extend EC2 driver list_nodes() method with ability to provide filters to list only specific nodes.

@@ -1875,7 +1875,7 @@ class BaseEC2NodeDriver(NodeDriver):
'terminated': NodeState.TERMINATED
}

def list_nodes(self, ex_node_ids=None):
def list_nodes(self, ex_node_ids=None, filters=None):
Copy link
Member

@Kami Kami Jun 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's an extension argument, it should be prefixed with ex - ex_filters.

Also, ex_node_ids and filters arguments are kinda overlapping (you could get the same result when using filters), but yeah, we should probably still leave it there for backward compatibility purposes.

@zerthimon
Copy link
Contributor Author

zerthimon commented Jun 23, 2014

Should parameter filters be renamed to ex_filters in other methods too (ex_list_networks, ex_get_security_groups, ex_list_route_tables and others in pending pull requests), for consistency ?

@zerthimon
Copy link
Contributor Author

zerthimon commented Jun 25, 2014

@Kami anything else to be done here ?

@Kami
Copy link
Member

Kami commented Jun 25, 2014

@zerthimon Nope. I'll go ahead and merge it shortly. Thanks.

@asfgit asfgit closed this in 8d93bf1 Jun 25, 2014
@Kami
Copy link
Member

Kami commented Jun 25, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants