Add network_association_id to ex_list_public_ips and CloudstackAddress obj...#327
Closed
boul wants to merge 1 commit intoapache:trunkfrom
Closed
Add network_association_id to ex_list_public_ips and CloudstackAddress obj...#327boul wants to merge 1 commit intoapache:trunkfrom
boul wants to merge 1 commit intoapache:trunkfrom
Conversation
Member
|
Merged thanks for the patch. Make sure to extend the test cases to check for this parameter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...ect
ex_list_networks should read ex_list_public_ips
With the network_association_id it is possible to relate and already acquired public ip to a network.
Without this information it is impossible to find out to which network a public ip belongs.