Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[LIBCLOUD-356] Add config_drive to support user_data #330
@stickystyle I think that's reasonable, although in cases like this, we usually leave validation like this to be performed by the server / API.
This way, we don't need to update the code if the business logic changes and passing one value without another becomes OK (which is unlikely in this case, but still).
@Kami I've updated the pull request to have config_drive as a kwarg, and didn't include the ValueError exception as I agree with you that leaving it up to the API is probably a more maintainable solution from the client side.
Let me know if there are any other changes that need to be made, thanks!