[LIBCLOUD-596] Add SSD support to GCE Compute driver #339
Conversation
| @@ -1182,6 +1183,15 @@ def create_node(self, name, size, image, location=None, | |||
| a GCEAddress object should be passed in. | |||
| :type external_ip: :class:`GCEAddress` or ``str`` or None | |||
|
|
|||
| :keyword disk_type: Specify a pd-standard (default) disk or pd-ssd | |||
There was a problem hiding this comment.
disk_type and disk_auto_delete are extension arguments so please prefix them with ex_ (ex_disk_type, ex_disk_auto_delete).
There was a problem hiding this comment.
(minor style thing) For consistency, please use single quotes around strings.
|
Thanks for the review @Kami! Addressed feedback and travis is happy. |
| @@ -1207,7 +1218,9 @@ def create_node(self, name, size, image, location=None, | |||
| request, node_data = self._create_node_req(name, size, image, | |||
There was a problem hiding this comment.
Not needed for this pull request, but eventually it would be nice to update this call to use keyword arguments.
|
Merged into trunk. Thanks. |
|
@Kami - I'm not sure how I managed to do this, but looks like I snuck in copy of the GCE driver, https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/gce.py.orig :-( |
|
Heh, I guess I've failed at the code review :) Anyways, good catch, removed in 0753835. |
Contributing support for SSD persistent disks to Google Compute Engine driver. SSD was recently introduced [https://developers.google.com/compute/docs/disks#typeofdisks].
Changed default disk size to 10 GB in test fixtures "just because".
@wrigri - mind taking a look?