New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-596] Add SSD support to GCE Compute driver #339

Closed
wants to merge 3 commits into
base: trunk
from

Conversation

Projects
None yet
2 participants
@erjohnso
Member

erjohnso commented Jul 16, 2014

Contributing support for SSD persistent disks to Google Compute Engine driver. SSD was recently introduced [https://developers.google.com/compute/docs/disks#typeofdisks].

Changed default disk size to 10 GB in test fixtures "just because".

@wrigri - mind taking a look?

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Jul 20, 2014

Member

Thanks for the review @Kami! Addressed feedback and travis is happy.

Member

erjohnso commented Jul 20, 2014

Thanks for the review @Kami! Addressed feedback and travis is happy.

@@ -1207,7 +1218,9 @@ def create_node(self, name, size, image, location=None,
request, node_data = self._create_node_req(name, size, image,

This comment has been minimized.

@Kami

Kami Jul 21, 2014

Member

Not needed for this pull request, but eventually it would be nice to update this call to use keyword arguments.

@Kami

Kami Jul 21, 2014

Member

Not needed for this pull request, but eventually it would be nice to update this call to use keyword arguments.

@asfgit asfgit closed this in e3edf27 Jul 21, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 21, 2014

Member

Merged into trunk. Thanks.

Member

Kami commented Jul 21, 2014

Merged into trunk. Thanks.

@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Jul 21, 2014

Member

@Kami - I'm not sure how I managed to do this, but looks like I snuck in copy of the GCE driver, https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/gce.py.orig :-(

Member

erjohnso commented Jul 21, 2014

@Kami - I'm not sure how I managed to do this, but looks like I snuck in copy of the GCE driver, https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/gce.py.orig :-(

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Jul 21, 2014

Member

Heh, I guess I've failed at the code review :)

Anyways, good catch, removed in 0753835.

Member

Kami commented Jul 21, 2014

Heh, I guess I've failed at the code review :)

Anyways, good catch, removed in 0753835.

@erjohnso erjohnso deleted the erjohnso:LIBCLOUD-596_SSD_for_GCE branch Oct 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment