Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-596] Add SSD support to GCE Compute driver #339

Closed
wants to merge 3 commits into from

Conversation

erjohnso
Copy link
Member

Contributing support for SSD persistent disks to Google Compute Engine driver. SSD was recently introduced [https://developers.google.com/compute/docs/disks#typeofdisks].

Changed default disk size to 10 GB in test fixtures "just because".

@wrigri - mind taking a look?

@@ -1182,6 +1183,15 @@ def create_node(self, name, size, image, location=None,
a GCEAddress object should be passed in.
:type external_ip: :class:`GCEAddress` or ``str`` or None

:keyword disk_type: Specify a pd-standard (default) disk or pd-ssd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disk_type and disk_auto_delete are extension arguments so please prefix them with ex_ (ex_disk_type, ex_disk_auto_delete).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor style thing) For consistency, please use single quotes around strings.

@erjohnso
Copy link
Member Author

Thanks for the review @Kami! Addressed feedback and travis is happy.

@@ -1207,7 +1218,9 @@ def create_node(self, name, size, image, location=None,
request, node_data = self._create_node_req(name, size, image,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for this pull request, but eventually it would be nice to update this call to use keyword arguments.

@asfgit asfgit closed this in e3edf27 Jul 21, 2014
@Kami
Copy link
Member

Kami commented Jul 21, 2014

Merged into trunk. Thanks.

@erjohnso
Copy link
Member Author

@Kami - I'm not sure how I managed to do this, but looks like I snuck in copy of the GCE driver, https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/gce.py.orig :-(

@Kami
Copy link
Member

Kami commented Jul 21, 2014

Heh, I guess I've failed at the code review :)

Anyways, good catch, removed in 0753835.

@erjohnso erjohnso deleted the LIBCLOUD-596_SSD_for_GCE branch October 17, 2014 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants