[LIBCLOUD-601] Add check windows os in is_valid_ip_address to run inet_aton#343
Closed
ashangit wants to merge 3 commits into
Closed
[LIBCLOUD-601] Add check windows os in is_valid_ip_address to run inet_aton#343ashangit wants to merge 3 commits into
ashangit wants to merge 3 commits into
Conversation
Member
There was a problem hiding this comment.
I guess there is still an edge case with IPv6 which inet_aton doesn't support, but inet_pton does.
Maybe we should throw if running on Windows and user specifies family=socket.AF_INET6.
Author
There was a problem hiding this comment.
In fact there is an issue with IPv6 when using inet_aton.
So we could throw an exception or use an external library dnspython wihich provide inet_aton for ipv4 and ipv6 and for windows also.
Let me know if adding such library is something acceptable or I will just add the throw.
Member
|
Sorry for the delay. I've added a check for validating IPv6 address on Windows (e105433) and merged changes into trunk. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.