Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudstack - create_node: add param to specify specific ip_address #346

Closed
wants to merge 1 commit into from

Conversation

@boul
Copy link
Contributor

@boul boul commented Aug 8, 2014

This will set a specific ip_address on the default NIC.

added tests for this too.

We need this functionality to deploy some instances with the same IP when recreating, this due to specific VPN/Firewall configuration for a particular customer.

@Kami
Copy link
Member

@Kami Kami commented Aug 8, 2014

LGTM.

/cc @Runseb

@@ -836,6 +839,7 @@ def _create_args_to_params(self, node, **kwargs):
ex_user_data = kwargs.get('ex_userdata', None)
ex_security_groups = kwargs.get('ex_security_groups', None)
ex_displayname = kwargs.get('ex_displayname', None)
ex_ip_address = kwargs.get('ex_ip_address', None)

This comment has been minimized.

@sebgoa

sebgoa Aug 8, 2014
Member

why do you have ex_ip_address in there but ex_ipaddress in the docstrings ?

This comment has been minimized.

@boul

boul Aug 8, 2014
Author Contributor

something between eyes and keyboard :)

@sebgoa
Copy link
Member

@sebgoa sebgoa commented Aug 8, 2014

Travis is failing on some minor flake8 issues…do you mind fixing it ?

…r default nic

plus flake8 & docstring fix
@boul
Copy link
Contributor Author

@boul boul commented Aug 8, 2014

squashed the commits including the docstring and flake8 fix

@asfgit asfgit closed this in 529a9cf Aug 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.