Cloudstack - create_node: add param to specify specific ip_address #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. /cc @Runseb |
| @@ -836,6 +839,7 @@ def _create_args_to_params(self, node, **kwargs): | |||
| ex_user_data = kwargs.get('ex_userdata', None) | |||
| ex_security_groups = kwargs.get('ex_security_groups', None) | |||
| ex_displayname = kwargs.get('ex_displayname', None) | |||
| ex_ip_address = kwargs.get('ex_ip_address', None) | |||
There was a problem hiding this comment.
why do you have ex_ip_address in there but ex_ipaddress in the docstrings ?
There was a problem hiding this comment.
something between eyes and keyboard :)
|
Travis is failing on some minor flake8 issues…do you mind fixing it ? |
…r default nic plus flake8 & docstring fix
|
squashed the commits including the docstring and flake8 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This will set a specific ip_address on the default NIC.
added tests for this too.
We need this functionality to deploy some instances with the same IP when recreating, this due to specific VPN/Firewall configuration for a particular customer.