Libcloud 544 gce metadata fix #349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2014 14:20
…on of the bugfix. We now perform a simple sanity check to know whether the metadata dictionary has already been formatted to GCE's specs.
| for k, v in ex_metadata.items()]} | ||
| if not ex_metadata or not isinstance(ex_metadata, dict): | ||
| # Should output a relevant error message if non-dict is received? | ||
| ex_metadata = None |
There was a problem hiding this comment.
We should throw ValueError if user passes in an invalid value (not a dictionary) instead of silently ignoring it.
added 4 commits
August 18, 2014 08:29
metadata field is provided.
1- Raise error correctly and separeta the "None" check from the malformed check
2- Provide comments explaining the odd GCE dictionary format
3- Perform check on metadata dictionary structure. We expect one "items" key
and a tuple of arbitrary values.
4- Prefix the key/value provided by a simple dictionary by "items", if not found,
enforcing point 3's structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly improved version of the fix i submitted minutes ago which had some trace-generating code in it. Removed my own silly tests.