New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libcloud 544 gce metadata fix #349

Closed
wants to merge 6 commits into
base: trunk
from

Conversation

Projects
None yet
3 participants
@raphtheb
Contributor

raphtheb commented Aug 15, 2014

This is a slightly improved version of the fix i submitted minutes ago which had some trace-generating code in it. Removed my own silly tests.

rtheberge added some commits Aug 15, 2014

rtheberge
[LIBCLOUD-544] Fix the regression caused by the original implementati…
…on of the bugfix. We now perform a simple sanity check to know whether the metadata dictionary has already been formatted to GCE's specs.

rtheberge added some commits Aug 18, 2014

rtheberge
Fix the metadata dictionary checks:
 1- Raise error correctly and separeta the "None" check from the malformed check
 2- Provide comments explaining the odd GCE dictionary format
 3- Perform check on metadata dictionary structure. We expect one "items" key
    and a tuple of arbitrary values.
 4- Prefix the key/value provided by a simple dictionary by "items", if not found,
    enforcing point 3's structure.
@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Aug 28, 2014

Member

@raphtheb - thanks for this. I've just tested it with SaltStack and this seems to work just fine. I'm guessing this is good to merge, but if I know @Kami, he'll ask you to squash your commits before merging. :)

Member

erjohnso commented Aug 28, 2014

@raphtheb - thanks for this. I've just tested it with SaltStack and this seems to work just fine. I'm guessing this is good to merge, but if I know @Kami, he'll ask you to squash your commits before merging. :)

@raphtheb

This comment has been minimized.

Show comment
Hide comment
@raphtheb

raphtheb Aug 29, 2014

Contributor

Thanks for havign a look, @erjohnso

For clarity, i am opening a new pull-request (#353) with only one clean, squashed commit from an alternate branch. The end diff is the same, but will allow for a cleaner history. This one can safely be ignored/destroyed/rejected.

Contributor

raphtheb commented Aug 29, 2014

Thanks for havign a look, @erjohnso

For clarity, i am opening a new pull-request (#353) with only one clean, squashed commit from an alternate branch. The end diff is the same, but will allow for a cleaner history. This one can safely be ignored/destroyed/rejected.

@raphtheb raphtheb closed this Aug 29, 2014

@raphtheb raphtheb deleted the raphtheb:LIBCLOUD-544_gce_metadata_fix branch Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment