[Libcloud-589] ProfitBricks Compute Driver Support #352

baldwinSPC · 2014-08-26T21:09:57Z

I have completed support for the ProfitBricks compute driver. This adds support for the core compute driver functions against ProfitBricks. The JIRA ticket can be found here:

https://issues.apache.org/jira/browse/LIBCLOUD-589

Let me know if there are any issues or if it can be accepted or not.

Thanks.
-matt

…ud project.

Kami · 2014-08-26T21:28:35Z

Sweet, thanks!

I will try to review it asap.

Kami · 2014-08-26T21:28:41Z

Travis build appears to be failing - https://travis-ci.org/apache/libcloud/builds/33635636

baldwinSPC · 2014-08-26T21:50:36Z

Thanks. Going through and correcting them now.

On Tue, Aug 26, 2014 at 2:28 PM, Tomaz Muraus notifications@github.com
wrote:

Travis build appears to be failing -
https://travis-ci.org/apache/libcloud/builds/33635636

—
Reply to this email directly or view it on GitHub
#352 (comment).

Kami · 2014-08-29T16:30:26Z

libcloud/compute/drivers/profitbricks.py

+            datacenter) for datacenter in object.findall('.//return')]
+
+    def _to_datacenter(self, datacenter):
+        elements = list(datacenter.iter())


Element.iter is not available in Python 2.6 (https://docs.python.org/2/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.iter), so please use findall instead (datacenter.findall('.//*')).

@Kami OK, this is corrected now: all spots where I use iter are now using findall.

Kami · 2014-09-02T21:35:17Z

libcloud/compute/drivers/profitbricks.py

+                                                      data=body,
+                                                      method='POST').object)
+
+    def destroy_node(self, node, remove_attached_disks=None):


Should default to False and not None.

Also, it's an extension argument so it should be prefixed with ex_.

Kami · 2014-09-02T21:58:48Z

Added some more comments.

When those are addressed, please squash all the commits.

Kami · 2014-09-06T13:30:06Z

@baldwinSPC How are things looking for those last couple of issues?

I will probably be preparing a new release this weekend and it would be great if those things could get addressed so I can also include this driver.

If you can't do it this weekend, let me know and I will do it myself (address those issues + squash the commits) while merging the patch.

baldwinSPC · 2014-09-06T17:57:39Z

Hey Tomaz

I've corrected about half of these. I'll commit and push those this
afternoon. I don't think I can correct the others, but what I'll do is
comment on the ones I've finished up.
On Sep 6, 2014 6:30 AM, "Tomaz Muraus" notifications@github.com wrote:

@baldwinSPC https://github.com/baldwinSPC How are things looking for
those last couple of issues?

I will probably be preparing a new release this weekend and it would be
great if those things could get addressed so I can also include this driver.

If you can't do it this weekend, let me know and I will do it myself
(address those issues + squash the commits) while merging the patch.

—
Reply to this email directly or view it on GitHub
#352 (comment).

baldwinSPC · 2014-09-07T04:37:55Z

@Kami I just pushed some updates that address most of the items you called out -- there are only two remaining ones: waiting for state and re-working the ET code.

Kami · 2014-09-07T16:34:58Z

@baldwinmathew Great, thanks.

I'll work on rest of the issues and try to get it merged tonight.

Kami · 2014-09-07T16:52:42Z

Another thing which got me confused while reviewing the changes:

PROVISIONING_STATE = {
        'INACTIVE': NodeState.PENDING,
        'INPROCESS': NodeState.PENDING,
        'AVAILABLE': NodeState.RUNNING,
        'DELETED': NodeState.TERMINATED,
    }

....

def _wait_for_datacenter_state(
            self,
            datacenter,
            state=PROVISIONING_STATE.get(NodeState.RUNNING),
            timeout=300,
            interval=5):

NodeState.RUNNING is mapped to int 0 (libcloud.compute.types.NodeState), but PROVISIONING_STATE dictionary contains strings as keys. Unless I am missing something, this means .get will always return None and _wait function will always time out.

Same goes with while condition - self.PROVISIONING_STATE.get(NodeState.PENDING).

I believe the state should default to state=PROVISIONING_STATE['available']. I will push those fixes to my branch and wait for you to review them before merging them into trunk.

1. Fix "ex_describe_datacenter" to return a single object instead of a list 2. Fix "ex_describe_datacenter" method signature to take an id instead of an object 3. Fix default value for "state" argument in the "_wait_for_datacenter_state" method 4. Fix while condition in the "_wait_for_datacenter_state" method 5. Modify "_wait_for_datacenter_state" to throw an Exception on timeout 6. Do the same fixes in the "_wait_for_storage_volume_state" method 7. Fix "ex_create_datacenter" to return single object instead of a list 8. Fix "create_volume" to return a single object instead of a list 9. Fix "ex_describe_node" to return a single object instead of a list 10. Fix "create_node" to retirn a single object instead of a list 11. Fix "attach_volume" to return volume on success 12. Fix "ex_create_network_interface" to return a single object instead of a list

Kami · 2014-09-07T17:58:38Z

@baldwinSPC I performed another review. During the review I still spotted many issues (mostly with function claiming it returns a single object but it actually returned a list) which I have fixed in my branch - Kami@28e9774

I would appreciate if you can go over my fixes, double check them and test them with the actual Profitbricks API (I don't have an account).

Thanks!

baldwinSPC · 2014-09-09T02:45:40Z

@Kami Great. Thanks Tomaz. I will be testing through this tomorrow morning and will update this thread.

Various fixes in the Profitbricks driver:

baldwinSPC · 2014-09-09T23:06:20Z

@Kami I just merged your branch into mine after testing all the methods live against the API. Everything looks good, however, in my testing I caught two bugs due to empty data coming back from their API. Those are two minor changes you should see on my next commit.

baldwinSPC · 2014-09-09T23:06:32Z

@Kami BTW, thank you for all your support. :)

Kami · 2014-09-12T09:54:07Z

@baldwinmathew Great and you are welcome.

I will look into your changes and and look into merging this pull request into trunk this weekend :)

Kami · 2014-09-14T11:31:26Z

Looks good.

I've made "a bunch of ifs" to "for loop" change and merged patch into trunk. Thanks!

baldwinSPC added 2 commits August 26, 2014 13:59

Pushing the PB compute driver into branch for PR to the Apache Libclo…

9543c95

…ud project.

[Libcloud-589] ProfitBricks Compute Driver Support

1aa90ad

baldwinSPC added 20 commits August 26, 2014 15:01

[Libcloud-589] Correcting issues raised in Travis CI.

69af4ed

[Libcloud-589] Correcting issues raised in Travis CI.

c54b183

[Libcloud-589] Correcting issues raised in Travis CI.

ec2f055

[Libcloud-589] Correcting issues raised in Travis CI.

0deda2c

[Libcloud-589] Correcting issues raised in Travis CI.

bc60f47

[Libcloud-589] Correcting issues raised in Travis CI.

337b977

[Libcloud-589] Correcting issues raised in Travis CI.

fab2a8a

[Libcloud-589] Correcting issues raised in Travis CI.

6619b90

[Libcloud-589] Correcting issues raised in Travis CI.

4a9b3c3

[Libcloud-589] Correcting issues raised in Travis CI.

17d7cd6

[Libcloud-589] Correcting issues raised in Travis CI.

db71d89

[Libcloud-589] Correcting issues raised in Travis CI.

fd4ed06

[Libcloud-589] Correcting issues raised in Travis CI.

30e1074

[Libcloud-589] Correcting issues raised in Travis CI.

4cb15b0

[Libcloud-589] Correcting issues raised in Travis CI.

ea48d15

[Libcloud-589] Correcting issues raised in Travis CI.

a07b405

[Libcloud-589] Correcting issues raised in Travis CI.

93d7cca

[Libcloud-589] Correcting issues raised in Travis CI.

6b5b143

[Libcloud-589] Correcting issues raised in Travis CI.

878dea9

[Libcloud-589] Correcting issues raised in Travis CI.

ba0ad33

Kami reviewed Aug 29, 2014
View reviewed changes

[Libcloud-589] Correcting issues raised in Travis CI.

a900d5e

Kami reviewed Sep 2, 2014
View reviewed changes

baldwinSPC added 4 commits September 6, 2014 21:06

corrects most of the feedback, but not quite all.

77c89ca

changed ex_describe_volume to take volume_id versus a volume.

24ff08c

correcting lint issue.

bf9ab46

Removed 'node' from the param list of detach_volume.

0904cb7

Merge pull request #1 from Kami/LIBCLOUD-589_profitbricks_compute_driver

560cd31

Various fixes in the Profitbricks driver:

fixed two minor issues when the pb api returns no data.

01beb7e

asfgit closed this in 34cff30 Sep 14, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Libcloud-589] ProfitBricks Compute Driver Support #352

[Libcloud-589] ProfitBricks Compute Driver Support #352

baldwinSPC commented Aug 26, 2014

Kami commented Aug 26, 2014

Kami commented Aug 26, 2014

baldwinSPC commented Aug 26, 2014

Kami Aug 29, 2014

baldwinSPC Aug 30, 2014

Kami Sep 2, 2014

Kami Sep 2, 2014

Kami commented Sep 2, 2014

Kami commented Sep 6, 2014

baldwinSPC commented Sep 6, 2014

baldwinSPC commented Sep 7, 2014

Kami commented Sep 7, 2014

Kami commented Sep 7, 2014

Kami commented Sep 7, 2014

baldwinSPC commented Sep 9, 2014

baldwinSPC commented Sep 9, 2014

baldwinSPC commented Sep 9, 2014

Kami commented Sep 12, 2014

Kami commented Sep 14, 2014

[Libcloud-589] ProfitBricks Compute Driver Support #352

[Libcloud-589] ProfitBricks Compute Driver Support #352

Conversation

baldwinSPC commented Aug 26, 2014

Kami commented Aug 26, 2014

Kami commented Aug 26, 2014

baldwinSPC commented Aug 26, 2014

Kami Aug 29, 2014

Choose a reason for hiding this comment

baldwinSPC Aug 30, 2014

Choose a reason for hiding this comment

Kami Sep 2, 2014

Choose a reason for hiding this comment

Kami Sep 2, 2014

Choose a reason for hiding this comment

Kami commented Sep 2, 2014

Kami commented Sep 6, 2014

baldwinSPC commented Sep 6, 2014

baldwinSPC commented Sep 7, 2014

Kami commented Sep 7, 2014

Kami commented Sep 7, 2014

Kami commented Sep 7, 2014

baldwinSPC commented Sep 9, 2014

baldwinSPC commented Sep 9, 2014

baldwinSPC commented Sep 9, 2014

Kami commented Sep 12, 2014

Kami commented Sep 14, 2014