Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-544] Resolve a bug introduced by the original fix of the issue... #353

Closed

Conversation

raphtheb
Copy link
Contributor

This is meant to replace github.com//pull/349
With one clean commit.

1- Add separated verifications for "None" and malformed metadata.
A clear error will be raised upon malformed metadata.
If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
found, enforcing point 3's structure.

…sue.

1- Add separated verifications for "None" and malformed metadata.
   A clear error will be raised upon malformed metadata.
   If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
   and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
   found, enforcing point 3's structure.
@erjohnso
Copy link
Contributor

👍 I tested this under the old #349 PR and this looks good to merge to me.

@asfgit asfgit closed this in 860674a Aug 29, 2014
@Kami
Copy link
Member

Kami commented Aug 29, 2014

Looks good. Thanks.

I've added tests and went ahead and merged patch into trunk.

@raphtheb raphtheb deleted the LIBCLOUD-544_gce_metadata_squashed branch August 29, 2014 17:41
@anglerud
Copy link

It would be great if this change could be added for ex_create_multiple_nodes' ex_metadata parameter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants