New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-544] Resolve a bug introduced by the original fix of the issue... #353

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
4 participants
@raphtheb
Contributor

raphtheb commented Aug 29, 2014

This is meant to replace github.com/apache/libcloud/pull/349
With one clean commit.

1- Add separated verifications for "None" and malformed metadata.
A clear error will be raised upon malformed metadata.
If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
found, enforcing point 3's structure.

rtheberge
[LIBCLOUD-544] Resolve a bug introduced by the original fix of the is…
…sue.

1- Add separated verifications for "None" and malformed metadata.
   A clear error will be raised upon malformed metadata.
   If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
   and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
   found, enforcing point 3's structure.
@erjohnso

This comment has been minimized.

Show comment
Hide comment
@erjohnso

erjohnso Aug 29, 2014

Member

👍 I tested this under the old #349 PR and this looks good to merge to me.

Member

erjohnso commented Aug 29, 2014

👍 I tested this under the old #349 PR and this looks good to merge to me.

@asfgit asfgit closed this in 860674a Aug 29, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Aug 29, 2014

Member

Looks good. Thanks.

I've added tests and went ahead and merged patch into trunk.

Member

Kami commented Aug 29, 2014

Looks good. Thanks.

I've added tests and went ahead and merged patch into trunk.

@raphtheb raphtheb deleted the raphtheb:LIBCLOUD-544_gce_metadata_squashed branch Aug 29, 2014

@anglerud

This comment has been minimized.

Show comment
Hide comment
@anglerud

anglerud Nov 14, 2014

It would be great if this change could be added for ex_create_multiple_nodes' ex_metadata parameter as well.

anglerud commented Nov 14, 2014

It would be great if this change could be added for ex_create_multiple_nodes' ex_metadata parameter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment