[LIBCLOUD-618] Make openstack create_volume return a StorageVolume #365
Conversation
|
Good catch. Merged into trunk. Thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The create_volume call in the OpenStack driver returns a bool to signify whether the call succeeded. This call should return a StorageVolume object, as other drivers already do (ec2, cloudstack, gce, etc).