CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test...#369
CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test...#369boul wants to merge 1 commit intoapache:trunkfrom
Conversation
boul
force-pushed
the
cs-add-remove-nic
branch
2 times, most recently
from
c217e33 to
2d6de86
Compare
|
@Runseb let me know if you want to get rid of those indent changes which slipped through, most probably because I switched to pycharm vs pydev. |
|
Hi @boul yes it would be nice to revert those indent changes. Next release will probably be in couple weeks |
boul
force-pushed
the
cs-add-remove-nic
branch
5 times, most recently
from
cd5ae38 to
40ae2d3
Compare
|
Reverted the slipped indents |
There was a problem hiding this comment.
Maybe better and more consistent names would be attach and detach (attach_nic_to_node, detach_nic_from_node).
There was a problem hiding this comment.
good suggestion, would you prefer to name the method attach_nic_to_node or ex_attach_nic_to_node, since it's a specific extension?
There was a problem hiding this comment.
Yeah, sorry, those should include ex_ prefix since they are extension methods.
boul
force-pushed
the
cs-add-remove-nic
branch
from
8c1ed81 to
6cd0d27
Compare
boul
changed the title
|
Allright, methods have been renamed (attach/detach vs add/remove) |
3 participants
Functionality to list NICS and to add/remove them too.
And some extra attribute maps with respect to nics.
Including unit tests
Some cosmetic (indent) change slipped in this commit as well.