New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test... #369

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@boul
Contributor

boul commented Oct 3, 2014

Functionality to list NICS and to add/remove them too.
And some extra attribute maps with respect to nics.
Including unit tests
Some cosmetic (indent) change slipped in this commit as well.

@boul

This comment has been minimized.

Show comment
Hide comment
@boul

boul Oct 7, 2014

Contributor

@runseb let me know if you want to get rid of those indent changes which slipped through, most probably because I switched to pycharm vs pydev.
When do you expect a new release with this functionality added?

Contributor

boul commented Oct 7, 2014

@runseb let me know if you want to get rid of those indent changes which slipped through, most probably because I switched to pycharm vs pydev.
When do you expect a new release with this functionality added?

@sebgoa

This comment has been minimized.

Show comment
Hide comment
@sebgoa

sebgoa Oct 7, 2014

Member

Hi @boul yes it would be nice to revert those indent changes. Next release will probably be in couple weeks

Member

sebgoa commented Oct 7, 2014

Hi @boul yes it would be nice to revert those indent changes. Next release will probably be in couple weeks

@boul

This comment has been minimized.

Show comment
Hide comment
@boul

boul Oct 8, 2014

Contributor

Reverted the slipped indents

Contributor

boul commented Oct 8, 2014

Reverted the slipped indents

Show outdated Hide outdated libcloud/compute/drivers/cloudstack.py
return nics
def ex_add_nic_to_node(self, node, network, ip_address=None):

This comment has been minimized.

@Kami

Kami Oct 9, 2014

Member

Maybe better and more consistent names would be attach and detach (attach_nic_to_node, detach_nic_from_node).

@Kami

Kami Oct 9, 2014

Member

Maybe better and more consistent names would be attach and detach (attach_nic_to_node, detach_nic_from_node).

This comment has been minimized.

@boul

boul Oct 9, 2014

Contributor

good suggestion, would you prefer to name the method attach_nic_to_node or ex_attach_nic_to_node, since it's a specific extension?

@boul

boul Oct 9, 2014

Contributor

good suggestion, would you prefer to name the method attach_nic_to_node or ex_attach_nic_to_node, since it's a specific extension?

This comment has been minimized.

@Kami

Kami Oct 11, 2014

Member

Yeah, sorry, those should include ex_ prefix since they are extension methods.

@Kami

Kami Oct 11, 2014

Member

Yeah, sorry, those should include ex_ prefix since they are extension methods.

@boul boul changed the title from CLOUDSTACK: ex_list_nics, ex_add_nic_to_vm, ex_remove_nic_from_vm + test... to CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test... Oct 13, 2014

@boul

This comment has been minimized.

Show comment
Hide comment
@boul

boul Oct 13, 2014

Contributor

Allright, methods have been renamed (attach/detach vs add/remove)

Contributor

boul commented Oct 13, 2014

Allright, methods have been renamed (attach/detach vs add/remove)

@boul

This comment has been minimized.

Show comment
Hide comment
@boul

boul Oct 23, 2014

Contributor

@Kami @runseb: Is there still something we need to fix before it can be merged into trunk? thx

Contributor

boul commented Oct 23, 2014

@Kami @runseb: Is there still something we need to fix before it can be merged into trunk? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment