Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test... #369

Closed
wants to merge 1 commit into from

Conversation

boul
Copy link
Contributor

@boul boul commented Oct 3, 2014

Functionality to list NICS and to add/remove them too.
And some extra attribute maps with respect to nics.
Including unit tests
Some cosmetic (indent) change slipped in this commit as well.

@boul boul force-pushed the cs-add-remove-nic branch 2 times, most recently from c217e33 to 2d6de86 Compare Oct 3, 2014
@boul
Copy link
Contributor Author

boul commented Oct 7, 2014

@Runseb let me know if you want to get rid of those indent changes which slipped through, most probably because I switched to pycharm vs pydev.
When do you expect a new release with this functionality added?

@sebgoa
Copy link
Member

sebgoa commented Oct 7, 2014

Hi @boul yes it would be nice to revert those indent changes. Next release will probably be in couple weeks

@boul boul force-pushed the cs-add-remove-nic branch 5 times, most recently from cd5ae38 to 40ae2d3 Compare Oct 8, 2014
@boul
Copy link
Contributor Author

boul commented Oct 8, 2014

Reverted the slipped indents


return nics

def ex_add_nic_to_node(self, node, network, ip_address=None):
Copy link
Member

@Kami Kami Oct 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better and more consistent names would be attach and detach (attach_nic_to_node, detach_nic_from_node).

Copy link
Contributor Author

@boul boul Oct 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion, would you prefer to name the method attach_nic_to_node or ex_attach_nic_to_node, since it's a specific extension?

Copy link
Member

@Kami Kami Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, those should include ex_ prefix since they are extension methods.

@boul boul changed the title CLOUDSTACK: ex_list_nics, ex_add_nic_to_vm, ex_remove_nic_from_vm + test... CLOUDSTACK: ex_list_nics, ex_attach_nic_to_vm, ex_detach_nic_from_vm + test... Oct 13, 2014
@boul
Copy link
Contributor Author

boul commented Oct 13, 2014

Allright, methods have been renamed (attach/detach vs add/remove)

@boul
Copy link
Contributor Author

boul commented Oct 23, 2014

@Kami @Runseb: Is there still something we need to fix before it can be merged into trunk? thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants