New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-622] Support for config_drive in the Openstack driver #370

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
2 participants
@rnirmal
Contributor

rnirmal commented Oct 9, 2014

Adds a 'ex_config_drive' option to create_node and ex_rebuild_node
for the Openstack driver.

@@ -40,7 +40,7 @@
}
]
},
"config_drive": "",
"config_drive": "True",

This comment has been minimized.

@Kami

Kami Oct 9, 2014

Member

Hm, so a value is a string and not a boolean?

@Kami

Kami Oct 9, 2014

Member

Hm, so a value is a string and not a boolean?

This comment has been minimized.

@rnirmal

rnirmal Oct 9, 2014

Contributor

Ah gotcha, yeah I was just mimicking what the api had, I'll get that changed to a boolean.

@rnirmal

rnirmal Oct 9, 2014

Contributor

Ah gotcha, yeah I was just mimicking what the api had, I'll get that changed to a boolean.

Show outdated Hide outdated libcloud/compute/drivers/openstack.py
@@ -1358,6 +1366,11 @@ def ex_rebuild(self, node, image, **kwargs):
Can be either ``AUTO`` or ``MANUAL``.
:type ex_disk_config: ``str``
:keyword ex_config_drive: Enables metadata injection in a server

This comment has been minimized.

@Kami

Kami Oct 9, 2014

Member

Even if the OpenStack API takes a string and not a boolean, Libcloud API should take a boolean and this should get converted to the OpenStack format inside the method.

@Kami

Kami Oct 9, 2014

Member

Even if the OpenStack API takes a string and not a boolean, Libcloud API should take a boolean and this should get converted to the OpenStack format inside the method.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 9, 2014

Member

Thanks.

There is a minor issue with a string / boolean in a public API, but besides that it looks good.

Member

Kami commented Oct 9, 2014

Thanks.

There is a minor issue with a string / boolean in a public API, but besides that it looks good.

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 9, 2014

Member

It would also be nice if you could add some documentation on how to use ex_config_drive and ex_userdata :)

Member

Kami commented Oct 9, 2014

It would also be nice if you could add some documentation on how to use ex_config_drive and ex_userdata :)

[LIBCLOUD-622] Support for config_drive in the Openstack driver
Adds a 'ex_config_drive' option to create_node and ex_rebuild_node
for the Openstack driver.
@rnirmal

This comment has been minimized.

Show comment
Hide comment
@rnirmal

rnirmal Oct 10, 2014

Contributor

The value is still a string on the API side, but I've set it up as a boolean on the client side. I've also added an example to show how to use it.

Contributor

rnirmal commented Oct 10, 2014

The value is still a string on the API side, but I've set it up as a boolean on the client side. I've also added an example to show how to use it.

@asfgit asfgit closed this in 4158507 Oct 11, 2014

@Kami

This comment has been minimized.

Show comment
Hide comment
@Kami

Kami Oct 11, 2014

Member

Merged into trunk. Thanks.

Member

Kami commented Oct 11, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment