Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-622] Support for config_drive in the Openstack driver #370

Closed
wants to merge 1 commit into from

Conversation

rnirmal
Copy link
Contributor

@rnirmal rnirmal commented Oct 9, 2014

Adds a 'ex_config_drive' option to create_node and ex_rebuild_node
for the Openstack driver.

@@ -40,7 +40,7 @@
}
]
},
"config_drive": "",
"config_drive": "True",
Copy link
Member

@Kami Kami Oct 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, so a value is a string and not a boolean?

Copy link
Contributor Author

@rnirmal rnirmal Oct 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha, yeah I was just mimicking what the api had, I'll get that changed to a boolean.

@Kami
Copy link
Member

Kami commented Oct 9, 2014

Thanks.

There is a minor issue with a string / boolean in a public API, but besides that it looks good.

@Kami
Copy link
Member

Kami commented Oct 9, 2014

It would also be nice if you could add some documentation on how to use ex_config_drive and ex_userdata :)

Adds a 'ex_config_drive' option to create_node and ex_rebuild_node
for the Openstack driver.
@rnirmal rnirmal force-pushed the LIBCLOUD-622_config_drive branch from 690100a to 602e531 Compare Oct 10, 2014
@rnirmal
Copy link
Contributor Author

rnirmal commented Oct 10, 2014

The value is still a string on the API side, but I've set it up as a boolean on the client side. I've also added an example to show how to use it.

@asfgit asfgit closed this in 4158507 Oct 11, 2014
@Kami
Copy link
Member

Kami commented Oct 11, 2014

Merged into trunk. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants