[LIBCLOUD-622] Support for config_drive in the Openstack driver #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "config_drive": "", | |||
| "config_drive": "True", | |||
There was a problem hiding this comment.
Hm, so a value is a string and not a boolean?
There was a problem hiding this comment.
Ah gotcha, yeah I was just mimicking what the api had, I'll get that changed to a boolean.
|
Thanks. There is a minor issue with a string / boolean in a public API, but besides that it looks good. |
|
It would also be nice if you could add some documentation on how to use |
Adds a 'ex_config_drive' option to create_node and ex_rebuild_node for the Openstack driver.
rnirmal
force-pushed
the
LIBCLOUD-622_config_drive
branch
from
690100a
to
602e531
Compare
|
The value is still a string on the API side, but I've set it up as a boolean on the client side. I've also added an example to show how to use it. |
|
Merged into trunk. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'ex_config_drive' option to create_node and ex_rebuild_node
for the Openstack driver.