Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK: Implemented VPC network acls and tests #371

Closed
wants to merge 2 commits into from

Conversation

boul
Copy link
Contributor

@boul boul commented Oct 9, 2014

VPC Support was already added in a previous commit, this commit also introduces support for ACLList on VPC's. Including unit tests. Thanks @jeroendekorte

% (self.id, self.displaytext, self.name,
self.vpc_offering_id, self.zoneid, self.cidr,
self.driver.name))
return (('<CloudStackVPC: id=%s, name=%s, '
Copy link
Member

@sebgoa sebgoa Oct 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the zone and display text ?

@boul
Copy link
Contributor Author

boul commented Oct 23, 2014

@Runseb I fixed the repr ordering as you suggested, to match the object order. I kept driver.name as this seems common in the project, see EC2NodeLocation for example. And i'm not sure what will break if I change this.

class EC2NodeLocation(NodeLocation):
def init(self, id, name, country, driver, availability_zone):
super(EC2NodeLocation, self).init(id, name, country, driver)
self.availability_zone = availability_zone

def __repr__(self):
    return (('<EC2NodeLocation: id=%s, name=%s, country=%s, '
             'availability_zone=%s driver=%s>')
            % (self.id, self.name, self.country,
               self.availability_zone, self.driver.name))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants