adds ex_security_group_ids to ec2 in order to be able to launch nodes with security groups on a VPC#373
Closed
Itxaka wants to merge 5 commits intoapache:trunkfrom
Itxaka:add_security_group_ids_for_vpc_on_ec2
Closed
adds ex_security_group_ids to ec2 in order to be able to launch nodes with security groups on a VPC#373Itxaka wants to merge 5 commits intoapache:trunkfrom Itxaka:add_security_group_ids_for_vpc_on_ec2
Itxaka wants to merge 5 commits intoapache:trunkfrom
Itxaka:add_security_group_ids_for_vpc_on_ec2
Conversation
added 3 commits
October 12, 2014 01:05
Contributor
Author
|
@Kami :) |
libcloud/compute/drivers/ec2.py
Outdated
Member
There was a problem hiding this comment.
This variable stores a list so it should be called security_group_ids.
Contributor
Author
|
@Kami ? |
Member
|
@Itxaka Sorry for the delay. I will have a look later today and hopefully also get it merged then. |
Member
|
LGTM. Patch has been merged into trunk. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to amazon having a different param for the security groups on an instance launched on a VPC and libcloud already supports VPCs (ex_subnet) this is the piece is missing to support the security groups on a VPC node
EC2 API page: http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-RunInstances.html