Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ex_security_group_ids to ec2 in order to be able to launch nodes with security groups on a VPC #373

Closed
wants to merge 5 commits into from
Closed

adds ex_security_group_ids to ec2 in order to be able to launch nodes with security groups on a VPC #373

wants to merge 5 commits into from

Conversation

Itxaka
Copy link
Contributor

@Itxaka Itxaka commented Oct 11, 2014

Due to amazon having a different param for the security groups on an instance launched on a VPC and libcloud already supports VPCs (ex_subnet) this is the piece is missing to support the security groups on a VPC node

  • adds a ex_security_group_ids kwarg which is a list of security group ids
  • checks for the existence of ex_subnet if ex_security_group_ids is called, as it depends on it to make sense
  • adds a test to see if the params are being constructed correctly

EC2 API page: http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-RunInstances.html

SecurityGroupId.n
One or more security group IDs. You can create a security group using CreateSecurityGroup.
Type: String
Default: Amazon EC2 uses the default security group.
Required: No
SecurityGroup.n
[EC2-Classic, default VPC] One or more security group names. For a nondefault VPC, you must use SecurityGroupId.n.
Type: String
Default: Amazon EC2 uses the default security group.
Required: No

@Itxaka
Copy link
Contributor Author

Itxaka commented Oct 11, 2014

@Kami :) :shipit:

raise ValueError('You can only supply ex_security_group_id'
' combinated with ex_subnet')

security_group_id = kwargs.get('ex_security_group_ids', None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable stores a list so it should be called security_group_ids.

@Itxaka
Copy link
Contributor Author

Itxaka commented Nov 19, 2014

@Kami ?

@Kami
Copy link
Member

Kami commented Nov 19, 2014

@Itxaka Sorry for the delay.

I will have a look later today and hopefully also get it merged then.

@Kami
Copy link
Member

Kami commented Nov 19, 2014

LGTM. Patch has been merged into trunk.

Thanks.

@asfgit asfgit closed this in d7c8671 Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants