New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK: Add option to expunge vm on destroy #382

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@boul
Contributor

boul commented Nov 7, 2014

No description provided.

"""
@inherits: :class:`NodeDriver.reboot_node`
:type node: :class:`CloudStackNode`
:keyword ex_expunge: If true is passed, the vm is expunged
immediately. False by default.

This comment has been minimized.

@sebgoa

sebgoa Nov 12, 2014

Member

might be better to set it to False by default then, and check if it's True before passing it.

@sebgoa

sebgoa Nov 12, 2014

Member

might be better to set it to False by default then, and check if it's True before passing it.

This comment has been minimized.

@Kami

Kami Nov 12, 2014

Member

Yeah, the docstring even says it defaults to False.

@Kami

Kami Nov 12, 2014

Member

Yeah, the docstring even says it defaults to False.

@boul

This comment has been minimized.

Show comment
Hide comment
@boul

boul Nov 12, 2014

Contributor

Check, changed the default to be False and only passing the arg when True as Cloudstack defaults to False so there is no need to send False to Cloudstack, this way it should also work with older CS versions which do not expose this feature.

Contributor

boul commented Nov 12, 2014

Check, changed the default to be False and only passing the arg when True as Cloudstack defaults to False so there is no need to send False to Cloudstack, this way it should also work with older CS versions which do not expose this feature.

@sebgoa

View changes

Show outdated Hide outdated libcloud/compute/drivers/cloudstack.py

@asfgit asfgit closed this in 680e23b Nov 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment