CLOUDSTACK: Add option to expunge vm on destroy #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| @inherits: :class:`NodeDriver.reboot_node` | ||
| :type node: :class:`CloudStackNode` | ||
|
|
||
| :keyword ex_expunge: If true is passed, the vm is expunged | ||
| immediately. False by default. |
There was a problem hiding this comment.
might be better to set it to False by default then, and check if it's True before passing it.
There was a problem hiding this comment.
Yeah, the docstring even says it defaults to False.
|
Check, changed the default to be False and only passing the arg when True as Cloudstack defaults to False so there is no need to send False to Cloudstack, this way it should also work with older CS versions which do not expose this feature. |
| 'id': node.id, | ||
| } | ||
|
|
||
| if ex_expunge is not False: |
There was a problem hiding this comment.
even better with:
if ex_expunge:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.