[google compute] improve MachineType (size) coverage of GCE API #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3508,11 +3508,27 @@ def _to_node_size(self, machine_type): | |||
| :rtype: :class:`GCENodeSize` | |||
| """ | |||
| extra = {} | |||
| disk_size = 10 | |||
There was a problem hiding this comment.
@erjohnso so we cannot change the disk_size through an argument ?
There was a problem hiding this comment.
@Runseb - no, you can't change parameters on a GCE MachineType. These are analogous to AWS "sizes" like x2.large, c2.medium (or whatever they are). They are static descriptions of the "size" of VM.
Google has made a change to the API since this code was originally contributed and now the most appropriate way to report a MachineType's disk size is to use maximumPersistentDisksSizeGb over the now rarely seen imageSpaceGb attribute.
There was a problem hiding this comment.
ok cool, I have not used GCE in couple months :)
erjohnso
added a commit
that referenced
this pull request
Nov 23, 2014
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes #396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to GCE Machine Types (sizes in libcloud parlance) to match GCE API.
GCENodeSizeextrasince they've been removed (namelyimageSpaceGb)Updated test fixture and test.