Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[google compute] improve MachineType (size) coverage of GCE API #396
Conversation
| @@ -3508,11 +3508,27 @@ def _to_node_size(self, machine_type): | |||
| :rtype: :class:`GCENodeSize` | |||
| """ | |||
| extra = {} | |||
| disk_size = 10 | |||
erjohnso
Nov 21, 2014
Author
Member
@Runseb - no, you can't change parameters on a GCE MachineType. These are analogous to AWS "sizes" like x2.large, c2.medium (or whatever they are). They are static descriptions of the "size" of VM.
Google has made a change to the API since this code was originally contributed and now the most appropriate way to report a MachineType's disk size is to use maximumPersistentDisksSizeGb over the now rarely seen imageSpaceGb attribute.
@Runseb - no, you can't change parameters on a GCE MachineType. These are analogous to AWS "sizes" like x2.large, c2.medium (or whatever they are). They are static descriptions of the "size" of VM.
Google has made a change to the API since this code was originally contributed and now the most appropriate way to report a MachineType's disk size is to use maximumPersistentDisksSizeGb over the now rarely seen imageSpaceGb attribute.
sebgoa
Nov 22, 2014
Member
ok cool, I have not used GCE in couple months :)
ok cool, I have not used GCE in couple months :)
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes #396
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes apache#396
Minor improvements to GCE Machine Types (sizes in libcloud parlance) to match GCE API.
GCENodeSizeextrasince they've been removed (namelyimageSpaceGb)Updated test fixture and test.