Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[google compute] improve MachineType (size) coverage of GCE API #396
Conversation
sebgoa
reviewed
Nov 21, 2014
| @@ -3508,11 +3508,27 @@ def _to_node_size(self, machine_type): | ||
| :rtype: :class:`GCENodeSize` | ||
| """ | ||
| extra = {} | ||
| disk_size = 10 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
erjohnso
Nov 21, 2014
Member
@runseb - no, you can't change parameters on a GCE MachineType. These are analogous to AWS "sizes" like x2.large, c2.medium (or whatever they are). They are static descriptions of the "size" of VM.
Google has made a change to the API since this code was originally contributed and now the most appropriate way to report a MachineType's disk size is to use maximumPersistentDisksSizeGb over the now rarely seen imageSpaceGb attribute.
erjohnso
Nov 21, 2014
Member
@runseb - no, you can't change parameters on a GCE MachineType. These are analogous to AWS "sizes" like x2.large, c2.medium (or whatever they are). They are static descriptions of the "size" of VM.
Google has made a change to the API since this code was originally contributed and now the most appropriate way to report a MachineType's disk size is to use maximumPersistentDisksSizeGb over the now rarely seen imageSpaceGb attribute.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
added a commit
that referenced
this pull request
Nov 23, 2014
added a commit
to erjohnso/libcloud
that referenced
this pull request
Dec 1, 2014
erjohnso commentedNov 20, 2014
Minor improvements to GCE Machine Types (sizes in libcloud parlance) to match GCE API.
GCENodeSizeextrasince they've been removed (namelyimageSpaceGb)Updated test fixture and test.